a quick revision & a little riddle "pause video while i type"

[ImprovedTube]

#2111

• this project started through https://github.com/code-charity/youtube/pull/2336/files

  • [ ] Revision: The code meant to only apply when the player is scrolled away anyways. But that's not working yet https://github.com/code-charity/youtube/blob/17f686bbc379b2f9ae8ccaa3f62b0fb50f28c857/js%26css/web-accessible/www.youtube.com/player.js#L1705

    • This can be a sub-option. Especially since it long started without it and we don't randomly impose changes. Yet there can't be to many extra toggles only appearing once enabling a feature (and especially our users care about details.)

  • [ ] Riddle: The feature works for typing comments, yet not while searching, despite that is also an INPUT https://github.com/code-charity/youtube/blob/17f686bbc379b2f9ae8ccaa3f62b0fb50f28c857/js%26css/web-accessible/www.youtube.com/player.js#L1685

    • Once again: Some users will already like this as is (for comments only) so we can keep this too as a sub-option too. "Only when typing a comment".

thanks

[ImprovedTube]

a solution event.target.isContentEditable. search input is already recognized here as an exception for our shortcuts. This can be used again

https://github.com/code-charity/youtube/blob/17f686bbc379b2f9ae8ccaa3f62b0fb50f28c857/js%26css/web-accessible/www.youtube.com/shortcuts.js#L98