code-charity
🐞Default channel tab not being applied to home page
Concise Description
Default channel tab not being applied to home page on Firefox
Browser/s
Firefox
Other Browser:
No response
'Steps to reproduce' - Which of our features is required for the bug to happen?
Set Default channel tab to videos
Since when?
Maybe around a week or 2 since i noticed it
Does the bug still happen when you log out of YouTube?
No
..No? Then please paste your yt.config_.EXPERIMENT_FLAGS. Twice (With the error & Without)
Can't fit here, longer than 65536. https://pastebin.com/dmfK3q5P
Are any errors or related log-messages shown in the Browser-Console? (F12)
No
Tested as the only active extension? (incognito mode or another browser users):
None
Expected preferred behavior:
No response
ImprovedTube Version
4.1323
Your Settings (From the Extension's ⋮-Hamburger menu > Settings > Backup & reset > Export settings)
No response
Your YouTube-Document
No response
OS / Device:
win 10 22h2
Hi! 👋 I’d love to work on this issue. Could you assign this to me? Thank you! 😊
Checked it on the main page, doesn't work for either now.
Okay so apparently the ImprovedTube.childHandler function just skips processing span elements, so when the link to the channel is inside of a span, it is ignored
What I did is i changed the childHandler method
https://github.com/code-charity/youtube/blob/5dbb0b7c1fda9207299926c009908d1de9041ecb/js%26css/web-accessible/functions.js#L4-L17
to handle cases when the span contains a link
if (node.nodeName === 'SCRIPT' || node.nodeName === 'iron-iconset-svg' || node.nodeName === 'svg' || (node.nodeName === 'SPAN' && !node.querySelector("a")) || node.nodeName === '#text' || node.nodeName === '#comment' || node.nodeName === 'yt-icon-shape' || node.nodeName === 'DOM-IF' || node.nodeName === 'DOM-REPEAT') {
return
}
Seems to fix the issue for me on the main page
thank you @LetonGerman @RIOplbLcDUxAUYIrJ
node.nodeName === 'DOM-IF' || node.nodeName === 'DOM-REPEAT'
since we are here, iirc this line may be subject to more change.., when our playlist features arent applied
