youtube icon indicating copy to clipboard operation
youtube copied to clipboard

Hide AI summary in all videos & "Display:none;"-conversation

Open wbalbo opened this issue 6 months ago • 11 comments

This should solve the issues #2901, #2645, and #2966

Tested on Chrome and Edge.

wbalbo avatar Jun 02 '25 21:06 wbalbo

thank you! @wbalbo

CSS display:none should be enough.

So ytd-expandable-metadata-renderer[has-video-summary] it is? ( The current version tests ytd-engagement-panel-section-list-renderer[target-id*="description"] from #2902 @Keerthi421 )


if await, for extension storage or our improvedtube.storage is necessary(?), then we should care for the whole extension at once.

ImprovedTube avatar Jun 02 '25 23:06 ImprovedTube

thank you! @wbalbo

CSS display:none should be enough.

So ytd-expandable-metadata-renderer[has-video-summary] it is? ( The current version tests ytd-engagement-panel-section-list-renderer[target-id*="description"] from #2902 @Keerthi421 )

if await, for extension storage or our improvedtube.storage is necessary(?), then we should care for the whole extension at once.

The current version doesn't work, I tried and tested with CSS only, we need the JS part.

The await is because I was trying to change it in real time, but it didn't work, and I didn't remove the async await part. I just removed and tested without it, and it worked fine.

wbalbo avatar Jun 02 '25 23:06 wbalbo

CSS should work persistently since the selector doesn't change: ( https://github.com/code-charity/youtube/commit/43109f396776afff3738e7d30e06ea5add58e469 ) https://github.com/code-charity/youtube/commit/fc3e7f279d87cdaff3da8423689353ff0b7b515d

unlike our broken playlist button injections, since the whole DOM elements might exist twice.

await

i see! 👍 (could be good /just reminds me to check anyways 😃 https://github.com/search?q=repo%3Acode-charity%2Fyoutube+storage-loaded&type=code )

ImprovedTube avatar Jun 03 '25 01:06 ImprovedTube

CSS should work persistently since the selector doesn't change: 43109f3

unlike our broken playlist button injections, since the whole DOM elements might exist twice.

await

i see! 👍 (could be good /just reminds me to check anyways 😃 https://github.com/search?q=repo%3Acode-charity%2Fyoutube+storage-loaded&type=code )

But this "ytd-engagement-panel-section-list-renderer" is not the correct one for the AI Summary.

The correct is the selector that I used on the JS file, "ytd-expandable-metadata-renderer"

wbalbo avatar Jun 03 '25 01:06 wbalbo

yes, my copy paste failed https://github.com/code-charity/youtube/commit/fc3e7f279d87cdaff3da8423689353ff0b7b515d

ImprovedTube avatar Jun 03 '25 01:06 ImprovedTube

I didn't test using CSS, but I guess should work? I used to use JS because of the toggle option, but I don't mind if you make it work on CSS and remove all the JS part.

wbalbo avatar Jun 03 '25 01:06 wbalbo

@wbalbo the html root element attributes are synced with our toggles: https://github.com/code-charity/youtube/blob/fc3e7f279d87cdaff3da8423689353ff0b7b515d/js%26css/extension/core.js#L266-L285

Which is convenient and efficient.
(However, CSS may be processed from right to left and might consume a bit, so for rare features we could still use JS to inject or generate CSS.)

( Themes: https://github.com/code-charity/youtube/blob/fc3e7f279d87cdaff3da8423689353ff0b7b515d/js%26css/extension/www.youtube.com/styles.css#L736-L2100 vs. https://github.com/code-charity/youtube/blob/fc3e7f279d87cdaff3da8423689353ff0b7b515d/js%26css/web-accessible/www.youtube.com/themes.js#L32-L88 )

ImprovedTube avatar Jun 03 '25 02:06 ImprovedTube

I didn't test using CSS, but I guess should work? I used to use JS because of the toggle option, but I don't mind if you make it work on CSS and remove all the JS part.

Will see soon. I tested your CSS selector with our dark mode* extension. you see it in the bottom here https://github.com/code-charity/crowd-fixes?tab=readme-ov-file#testing-methods (linked form here https://github.com/code-charity/youtube?tab=readme-ov-file#-vision-for-open-source-efficiency--auto-contributors)
( ImprovedTube also has a custom css feature but somehow it wasnt migrated correctly years ago 🙈 and if we'd support (+crowdsource) ublock rules, we'd not even need separate code and consideration for a 'simple features framework' including #2251 - https://github.com/code-charity/letsblockit was a server for ublock rules but ended)

..* Dark mode easily found 20000 user (despite it is confusing currently, many leave. it does have uniquely thought-through specificity beyond dark reader. But in the end the author quit at more of an alpha release. The main-switch functionality is confusing or flawed. Back then he also added something obviously relaxing, that i suggested back then, to make any page start fading in from a dark/er background - Instead of the browser flashing full white at us up to every click - but i didn't start using it yet. i think it would need some tuning / settings. )

But more importantly please have a look at the old vision of history manager https://chromewebstore.google.com/detail/history-manager/odognhgojidbcgconbcipmgffjcmfaoj there is so much we could add. ( empowering/meaningful self data management projects also can get various funding. ) - An inspiration also can be FastestSearch (requires palemoon or old firefox with https://github.com/JustOff/ca-archive ) and the Auto Text Pattern selector linked here https://github.com/code-charity/ultimate-REGEX-extension/issues/4

Our extensions share satus.js. For current separation and raising developer motivation, I moved some "global extension ideas" here: https://github.com/code-charity/Wish-Factory/issues/17 and converted them to discussions, just so it could provide list ordered by votes like reddit🙈 - Yet ImprovedTube will need to to trigger permissions dialog once too and offer to run on all pages and #1881 and i guess i would rather organize the ultimate extension framework, combining all said here, than too many separate / abandoned ones? (yet youtube alone makes a high percentage (50%?) of all time people spend with their web browsers.)

(hope this "random massage" / perspective is bookmark-worthy or something) thanks for all your work again!

ImprovedTube avatar Jun 03 '25 23:06 ImprovedTube

Yeah, they're worth it for sure.

I guess the ideas from Wish Factory should be implemented once we have enough votes/people interested.

And yes, there are a lot of things to add, maybe we should have something like a "To-Do" list in a specific place? I guess we can use the Projects tab to better organize? Never used, so just a guess.

Always happy to help in my free time.

wbalbo avatar Jun 03 '25 23:06 wbalbo

I guess the ideas from Wish Factory should be implemented once we have enough votes/people interested

maybe in that hidden spot not even a perfect to-do list would have many votes yet? (with the most global features saving the most time and the most easy to implement and understand combined). Yet could be pro-active step by step, we could invite our users to watch what matters. Hope to find and or hire a bit of a team.

About 5 billion people have been online for more than 5 years.
Youtube counts about 140 billion minutes per day according to similarweb.
125 million pay youtube premium.
38 million had a channel with more than 10 subscribers ( 2022 data #1451)

ImprovedTube avatar Jun 04 '25 03:06 ImprovedTube

PART-2: https://github.com/code-charity/youtube/pull/2983#issuecomment-2942402379

ImprovedTube avatar Jun 07 '25 06:06 ImprovedTube