code-charity
[Feature Request] Windowed Fullscreen
| SHORT Table | (Summary) |
|---|---|
| Problem | none |
| Solution | none |
| Alternatives | https://addons.mozilla.org/en-US/firefox/addon/youtube-window-fullscreen/ |
| Scope | |
| Side effects | has gone paid only would like to see this similar feature in your extension |
| Context | use to be open source but has gone paid and closed source so i no longer really trust it |
Ok, I need to first confirm with @ImprovedTube because my solution added some permissions to manifest.json, and I am not sure if he is ok with that, e.g
Also, my Back button (top left side) is horrible, style-wise. But the solution itself is not too hard to implement.
thank you for putting in this effort :)
Glad to help, and I use this extension so it will also help me =)
About the button, I removed it and instead coded to use the same shortcut (Ctrl+Shift+E) to enter and leave the windowed mode. I will wait for a reply to proceed and create a PR for this.
Actually there's other "yt enhancer" chrome extension has this "windowed fullscreen" feature, only using css rules to "maximise" the video player to the size of DOM body, but that only works for normal video page, not shorts.
I adapted that idea and put it into my own extension and made it work for shorts too.
hi @madmaxgrey @wbalbo @RichardReallyHard Thank you so much for caring again @wbalbo and sorry for the delay. I started answering here but lost the tab somehow. We have the following:
- Appearance:player:fit to window; or fit to page (max. width or max. height)
- A "Fit-to-window"-Player button (which actually triggers max. height, so the diagonal arrow icon is wrong
- Pop-out player window (embedded player with the same size as on the page)
Please have a look at all of this to define what's the best (most useful and easy) for you guys and everybody else too.
We also have a custom shortcuts section for simple shortcuts beyond standard browser shortcuts @wbalbo. Yet both make their sense. Just hoping you will join this project's structure.
Permissions: "tabs" triggers a warning: https://developer.chrome.com/docs/extensions/reference/permissions-list - Can you make it optional (requested when enabling the feature), so that they dont tirgger a warning for everybody (you can also shortly state a reason what for each permission so that google might accept it sooner)
thanks!
hi @madmaxgrey @wbalbo @RichardReallyHard Thank you so much for caring again @wbalbo and sorry for the delay. I started answering here but lost the tab somehow. We have the following:
Appearance:player:fit to window; or fit to page (max. width or max. height)
- A "Fit-to-window"-Player button (which actually triggers max. height, so the diagonal arrow icon is wrong
Pop-out player window (embedded player with the same size as on the page)
Please have a look at all of this to define what's the best (most useful and easy) for you guys and everybody else too.
We also have a custom shortcuts section for simple shortcuts beyond standard browser shortcuts @wbalbo. Yet both make their sense. Just hoping you will join this project's structure.
Permissions: "tabs" triggers a warning: https://developer.chrome.com/docs/extensions/reference/permissions-list - Can you make it optional (requested when enabling the feature), so that they dont tirgger a warning for everybody (you can also shortly state a reason what for each permission so that google might accept it sooner)
thanks!
Yeah, I didn't investigate the extension too much prior to my PR, haha.
I guess this option is already fulfilling the @madmaxgrey request
The result is pretty good and the same as what I implemented
I guess my PR can be abandoned, @ImprovedTube
besides we can fix/update and merge things, add new sub-options and linguistically refine it all. And we now might be the most likely to do so 😅. (This feature [or set of features] is popular, and missed in our extension and the web-store picture used to advertise it for years. I have written a few more notes about in Github issues before.)
We will also trigger the permissions dialogue for all users again anyways @wbalbo ( To support more URLs m.youtube, facebook.com/watch and all sites 1881#:~:text=Inspiring%20examples%20(%20%2Dhow%20to%20connect%20with%20them%3F)%20%3A and smart features / https://github.com/code-charity/youtube/issues?q=is%3Aopen+label%3A%22Filtering+%26+Discovery+%28of+Content%29%22++OR+label%3A%22Set+%26+forget+%28automatic+feature%29%22+ )
besides we can fix/update and merge things, add new sub-options and linguistically refine it all. And we now might be the most likely to do so 😅. (This feature [or set of features] is popular, and missed in our extension and the web-store picture used to advertise it for years. I have written a few more notes about in Github issues before.)
We will also trigger the permissions dialogue for all users again anyways @wbalbo ( To support more URLs m.youtube, facebook.com/watch and all sites 1881#:~:text=Inspiring%20examples%20(%20%2Dhow%20to%20connect%20with%20them%3F)%20%3A and smart features / https://github.com/code-charity/youtube/issues?q=is%3Aopen+label%3A%22Filtering+%26+Discovery+%28of+Content%29%22++OR+label%3A%22Set+%26+forget+%28automatic+feature%29%22+ )
Yeah, there are so many useful features that sometimes it's hard to let the users know everything, right?
But in this case, I guess I can close my PR because there is already a useful feature implemented.
Thanks for looking into it.