youtube icon indicating copy to clipboard operation
youtube copied to clipboard

Always jumps to the description part

Open merlin555 opened this issue 1 year ago • 61 comments


re-opening: https://github.com/code-charity/youtube/issues/2499#issuecomment-2381454057



Hello everyone,

For 1-2 weeks I have had the following problem in the Vivaldi browser when I load YouTube. Instead of the usual way that you log in after the page has loaded, is right at the top, it is always at the beginning with the description. Only “reload page” helps. This problem does not exist in Firefox.

Here is a video that shows the whole problem: https://mega.nz/file/JhpW2LBB#-LKyXZ2wxmZYqlZ5Y1JgQlbdBgSaLt8Oc06at-zOWSM

And here's mine "improvedtube.json" file. improvedtube.json

Regards,

Merlin

merlin555 avatar Jul 30 '24 14:07 merlin555

hi! @merlin555 you can check the fix here: https://chromewebstore.google.com/detail/improve-youtube-test-for/lodjfjlkodalimdjgncejhkadjhacgki

ImprovedTube avatar Jul 30 '24 18:07 ImprovedTube

(to be closed when the main version is updated)

ImprovedTube avatar Jul 30 '24 18:07 ImprovedTube

Google is delaying the update. (Our Beta with 20000 users is updated quickly or automated often).
The main version usually has to wait a day or so for updates. (And sometimes it might takes a week. Sais: "spam violation" again (the word youtube was used "too much". - Yet we made this necessary update to avoid this bug and didn't change the description. And already replaced most occurrences with "YT" before. Next time we might just delete the whole description, which would do less harm.) (until now the word appeared 9 times in the description (little to describe our 180 features and toggles. And 6 times in the two mentioned magazine review links with quote. While "adblock for youtube" for example uses the word 17 times 🤷 and has 9-10 million users and one feature https://chromewebstore.google.com/detail/adblock-for-youtube/cmedhionkhpnakcndndgjdbohmhepckk)

ImprovedTube avatar Jul 30 '24 18:07 ImprovedTube

@ImprovedTube

Works well so far. Just with a delay.

Thanks!

Forgot to mention, the problem only occurs when you open the video in a new TAB. If you open the video in the same TAB, this problem doesn't exist.

merlin555 avatar Jul 30 '24 19:07 merlin555

How much delay? Didn't change that. Description should expand as soon as it is loaded or maybe after 0.x seconds - if it loaded late. The addition/change is only to deny youtube's scripts to scroll in the right moment. https://github.com/code-charity/youtube/blob/6171f185f9e40b74ceb007c51da6b03de61b4d20/js%26css/web-accessible/www.youtube.com/appearance.js#L458-L484

ImprovedTube avatar Jul 30 '24 22:07 ImprovedTube

Happening on Firefox 128.0.3

Corruptinglyneedful avatar Jul 31 '24 02:07 Corruptinglyneedful

@ImprovedTube

Let's say 0.3 - 0.5 seconds. It's not always the same. It's best to open several TABs in the background to test.

I've never had this problem under Firefox v128.0.3 until now.

merlin555 avatar Jul 31 '24 05:07 merlin555

@ImprovedTube

If the "Auto Cinema Mode" (Player) is turned on in the settings, it doesn't work. Except mostly the first 3 new TABS that you open in the background. The following ones remain in the middle. Sometimes only the first TAB that you open in the background works.

Reloading the page (F5 key) always solves the problem.

merlin555 avatar Jul 31 '24 06:07 merlin555

hi @Corruptinglyneedful!

So you only got the bug with both features enabled? @merlin555 - Cinema mode is new(@SanderDebets); (Auto requires the button to be enabled too as you noticed) & reminded me to also release General: "Dim Youtube's Pages, except what I mouse-over!" (can you compare that? We don't have to hide stuff completely. But it can depend both mouse-over (hover) and pause/play (and we can allow to set the exact percentage of transparency)

  • Just noticed @raszpl worked on cinema mode too weeks ago (without committing). Let's show him much more appreciation for his MANY commits and pull-requests(, which usually can be sent to all users quickly!)

    • We can keep all 3 toggles named differently @raszpl or more: Cinema mode :
      while playing the video? before starting the video? while pausing the video? ; button? shortcut?
      - as often: https://github.com/code-charity/youtube/issues/1935#issuecomment-2102780658 ( ; https://github.com/MarcGuiselin/youtube-refined ; #2251 ; https://github.com/code-charity/youtube/labels/Structures%20%28UX%29%20%26%20ORG )

ImprovedTube avatar Jul 31 '24 11:07 ImprovedTube

@ImprovedTube

The thing about “Cinema Mode” was wrong. It has nothing to do with it, I just realized. I thought it was in "Cinema Mode" because it hasn't worked properly again since today. Yesterday it still worked as written. Now it's causing problems. The first few TABS work as written above, where I suspected “Cinema Mode”. Something changed again on YouTube today.

merlin555 avatar Jul 31 '24 12:07 merlin555

thanks @merlin555, with the fix or without?

ImprovedTube avatar Jul 31 '24 12:07 ImprovedTube

@ImprovedTube

With 4.1077 the problem is always there. With the "FIX" the first newly opened TABS almost always work in the background where you open. Before, even the first 5 TABS worked. With the 6th TAB it stopped working. It's not always the same. But if it doesn't work, then all the following TABS won't work either.

merlin555 avatar Jul 31 '24 13:07 merlin555

The addition/change is only to deny youtube's scripts to scroll in the right moment.

forbidding the scrolling for 3.6s instead of 1.2s in background tabs https://github.com/code-charity/youtube/commit/dd1f7f9bbd823074c11b3381e85182dd1f9a1d5d?diff=unified&w=1 https://github.com/code-charity/youtube/blob/dd1f7f9bbd823074c11b3381e85182dd1f9a1d5d/js%26css/web-accessible/www.youtube.com/appearance.js#L463

(you can try latest changes @chrome://extensions developer mode load unpacked )

ImprovedTube avatar Jul 31 '24 18:07 ImprovedTube

hi @Corruptinglyneedful!

I am not quite sure what you are asking me. All I know is I am on the Firefox version and it is jumping the page down to about the description on nearly every video and I'm quickly growing tired of this bug. It wasn't doing this before and I'd like to know what is causing it and more importantly how to fix it.

Corruptinglyneedful avatar Jul 31 '24 19:07 Corruptinglyneedful

@Corruptinglyneedful
Youtube is doing that when expanding the description. Yet we prevent that, when our feature "description: expanded" runs. When exactly did this start for you? (a fix was published in firefox 3 days ago) Try to log out too

ImprovedTube avatar Jul 31 '24 23:07 ImprovedTube

@Corruptinglyneedful Youtube is doing that when expanding the description. Yet we prevent that if when our the feature "description: expanded" runs. When exactly did this start for you? (a fix was published in firefox 3 days ago) Try to log out too

It has been doing it a number of weeks now. It is still doing it today. Is there a setting I should untick/tick because I don't have the description set to show. I have to click show more.

Corruptinglyneedful avatar Aug 01 '24 00:08 Corruptinglyneedful

@Corruptinglyneedful what are all your settings? try disabling appearance options player size, header, transcript, chapters. beyond that it also just takes a few clicks to try an old version with all your settings: https://addons.mozilla.org/en-US/firefox/addon/youtube-addon/versions/
thanks

ImprovedTube avatar Aug 01 '24 12:08 ImprovedTube

@Corruptinglyneedful what are all your settings? try disabling appearance options player size, header, transcript, chapters. beyond that it also just takes a few clicks to try an old version with all your settings: https://addons.mozilla.org/en-US/firefox/addon/youtube-addon/versions/ thanks

Do you have a way to dump those settings to a file I can send within the extension? There are way too many settings to just simply list them all out and I would not know if one is conflicting or w/e. When I first installed this, I went through every available option and looked and tweaked here and there. It could be literally anything doing it.

And I'm not too keen on being locked to an old version. With something that moves as fast as Youtube changes do, you have to stay current.

Corruptinglyneedful avatar Aug 01 '24 18:08 Corruptinglyneedful

I can confirm this issue, too. It started just a few weeks ago for me also.

My guess is, that it is the auto generated content added by YouTube into the videos description which cannot be hidden by any means of the extension by now. When loading the page, you first see the top with the video, it then »jumps« directly down to this in the desctiption (at the end of it) and then jumps back to the top.

I think this could be prevented by hiding/blocking that part which is useless anyway. There even is a text string stating auto generated by YouTube at the beginning and it mostly points to shorts containing the video and other »related« content.

Just went through all the extensions settings and wether found a way to hide/block it nor anything else which might cause this. I tried using the element picker from uBlock Origin to just block this part but only found I can block the whole description or nothing, so a more detailed selection is needed.

LinguaOccultus avatar Aug 02 '24 15:08 LinguaOccultus

@LinguaOccultus

Thank you for your information.

merlin555 avatar Aug 02 '24 15:08 merlin555

@LinguaOccultus

Thank you for your information.

I am using Vivaldi (another Chromium-based Browser of the former Opera developers until version 12.xx) and I am used to messing around with this extension as it often is having issues in this browser.

At the moment, it was working relatively well and it became essential to stop all the bullshit and bloat-stuff on YouTube. I did test alternatives but found this one the best in the end.

I also do understand that the website of YouTube is permanently changing and the extension needs to be adjusted accordingly as many other extensions for the very same reason. However, the web today is barely a useful place without an ad and cookie note blocker and my other extension to customize your most used pages or extend their functionality.

But even though I am technically experienced, alone out of need, I could not solve this one when it started. The only workaround might be, hiding or at least collapsing the details until this is adressed but I fear, we have to wait for a fix – or better: a function to hide/block this new bullshit – here.

I can also confirm that I have set my details panel to being expanded automatically so you do not have to click it all the time for that (who ever thought this is a good idea instead of stopping to put all the unasked content into it). So, at the moment it seems, there is only tradeoff possible.

Edit: I attached my settings JSON file if that helps in any way. Whith this settings, the issue can be still seen. improvedtube.json

LinguaOccultus avatar Aug 02 '24 15:08 LinguaOccultus

@LinguaOccultus

I just imported and tested your settings. I have quite a problem with that.

  1. On the main page of "ABOS" certain thumbnails are cut off from the videos.

  2. The videos themselves cannot be played in the tab that is open in the background. The "Play" button doesn't work, the one in the video itself and at the bottom of the bar. Sometimes it helps to reload the page with the F5 key, but not always.

  3. The thumbnails in the video itself, where you can jump in the timeline, are moved downwards.

Here is a video I recorded about it. https://mega.nz/file/IwhwGYrI#YyDHvqVmcSRa21fSqc50chFaMomhQ4zkTveJOlzmjuo

And here again my current setting file. improvedtube.json

merlin555 avatar Aug 02 '24 17:08 merlin555

I disabled force theater mode in the extension. This may have resolved it. I watch Youtube like all day long so I will let you know if it comes back. It also could have been the update on Aug 1.

Corruptinglyneedful avatar Aug 02 '24 19:08 Corruptinglyneedful

@merlin555

I am not at home currently so I can only share information but cannot test anything.

Some of your issues sound like a conflict with another extension or browser setting. I myself have found that an issue with stopping autoplay was caused by the setting being enabled in the browser (Vivaldi has one but it does not work in most cases; known bug still unsolved) and by using an extension for it together. Also, blockers like uBlock Origin and such easily can break websites. You could test in a new profile with just this extension or the YouTube website in a private tab to further track the issue down. Sometimes, when trying to hard to confirm an issue to a specific source in question one forgets that others might cause it aswell. Also happened to myself several times before. ;-)

But I can confirm that I do not have any of those issue in my side so far (aside from abos which I do not use and without being able to test your config). However, as there are so much possible combinations of settings in the extension, this comes without a surprise.

@Corruptinglyneedful : I had this setting enabled before as I have overseen there is an option to disable that nasty effect meanwhile, but I have the very same jumping issue with and without it. This, however, could be easily explained since some of the settings might affect other in a good or bad way together with the ever changing YouTube website ...

@ImprovedTube : Could you maybe test our configs on your side to see if you can reproduce those issue and if they help to find the cause? If more informations or testing is needed, just tell me. As soon as I find the time, I will go through the whole thread in detail to see what hase been asked/tested/done so far ...

LinguaOccultus avatar Aug 02 '24 22:08 LinguaOccultus

@LinguaOccultus

It's quite possible that another extension is causing a conflict. I only have the problem I describe above when I import your settings, not otherwise.

Important What I noticed after I imported your settings and then imported my settings again, your settings were still there. I've noticed this problem before and it's very important to do this before importing the settings. that you first “Reset all settings.

merlin555 avatar Aug 03 '24 03:08 merlin555

Hmmm ... if some of the issues are caused by my settings – which I guesses from the very beginning – I have not been able to identify those (aside from what I explained above in my first reply). I think there really is just need to adjust the extension.

Regarding the settings import/export this is normally a replacement procedure with most applications. In some cases, only a partial backup/restore is done but even then the settings in question should be replaced. What I guess here is, that I changed settings you did not and it imported them and mixed everything up. Normally, unchanged settings should be reset to their default value which seems to be not happening here. Also something the developer needs to take care of. I am only exporting them for my systems for backup/restore reasons but under that conditions, I need to take care of them in a different way even in this case. Good observation, though!

Yet, as I have seen above this will be closed when they rolled out the fix for the jump issue, you should open a separate bug report for it.

LinguaOccultus avatar Aug 03 '24 10:08 LinguaOccultus

@LinguaOccultus

I'm just going to do it. Thanks for the tip.

merlin555 avatar Aug 03 '24 11:08 merlin555

YT changed the way expand description works, it now grabs focus, scrolls and draws stupid frame around Description fixed in https://github.com/raszpl/tweaks4ytube/blob/927b909a4392176ce1db8cc54e17e95e1a231955/js%26css/web-accessible/www.youtube.com/appearance.js#L421

raszpl avatar Aug 03 '24 17:08 raszpl

hi! @LinguaOccultus

Could you maybe test our configs

sure! 👍 if necessary

Yet, as I have seen above this will be closed

yes! should have closed this most likely.

...something the developer needs to take care of. I am only exporting...

Import Settings always worked like this - it doesnt replace old settings with new ones, it adds new settings on top of old ones

(https://github.com/code-charity/youtube/issues/2506#issuecomment-2267148185)


hi! @raszpl 👍

what does L421 change / fix? (+why not wrap the (any) feature in if (this.storage.description === 'expanded') { .... } ( Fixed like this yet: https://github.com/code-charity/youtube/blob/b9ab7ae071ccd09343e1d1a6c02f442ec08652d5/js%26css/web-accessible/www.youtube.com/appearance.js#L457-L467 )


@merlin555

I have quite a problem with that.

Some of your issues sound like a conflict with another extension or browser setting. I myself have found that an issue with stopping autoplay was caused by the setting being enabled in the browser (Vivaldi has one but it does not work in most cases; known bug still unsolved) and by using an extension for it together. Also, blockers like uBlock Origin and such easily can break websites. You could test in a new profile with just this extension or the YouTube website in a private tab to further track the issue down. Sometimes, when trying to hard to confirm an issue to a specific source in question one forgets that others might cause it aswell. Also happened to myself several times before. ;-)

But I can confirm that I do not have any of those issue in my side so far (aside from abos which I do not use and without being able to test your config).

interesting!


@Corruptinglyneedful:

Do you have a way to dump those settings to a file I can send within the extension?

yes top right settings, backup, export

not too keen on being locked to an old version.

firefox allows to switch version easily as if it was an extension feature (so thats a great tool for testing /making sure)

ImprovedTube avatar Aug 03 '24 23:08 ImprovedTube

I've had several hours now and since I disabled Forced Theater mode setting and just went to using the button on the player directly, I've had no more problems with it jumping to the description. So it was either that or an update that fixed it.

Corruptinglyneedful avatar Aug 04 '24 03:08 Corruptinglyneedful