youtube icon indicating copy to clipboard operation
youtube copied to clipboard

Suggestion Center video player button icons

Open CatsArmy opened this issue 1 year ago • 6 comments

Hear me out ok.

when you have a the Share, Download, Super Thanks and the Clip ( and the other ones idk) buttons set to: Icon only you should probably center the icon(svg) so it looks nicer let me show you what i tried:

Currently it looks like this with the said settings: image

But if you do as i suggest it will look like this: image

Note: For some reason when i use the dev tools in the browser it and i resize the html code viewer it just removes some of the buttons don't think this is because of this extension just saying it because the pictures look a bit different.

This can be done by adding style="margin-left:auto; margin-right:auto; display:block;" to the style to the html adding the svg icon

<div class="yt-spec-button-shape-next_icon" style="margin-left:auto; margin-right:auto; display:block;">

Here are some examples of how i did it:

Share Button:

changed this:
<div class="yt-spec-button-shape-next__icon" aria-hidden="true"><yt-icon style="width: 24px; height: 24px;"><!--css-build:shady--><!--css-build:shady--><yt-icon-shape class="style-scope yt-icon"><icon-shape class="yt-spec-icon-shape"><div style="width: 100%; height: 100%; display: block; fill: currentcolor;"><svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24" focusable="false" style="pointer-events: none; display: inherit; width: 100%; height: 100%;"><path d="M15 5.63 20.66 12 15 18.37V14h-1c-3.96 0-7.14 1-9.75 3.09 1.84-4.07 5.11-6.4 9.89-7.1l.86-.13V5.63M14 3v6C6.22 10.13 3.11 15.33 2 21c2.78-3.97 6.44-6 12-6v6l8-9-8-9z"></path></svg></div></icon-shape></yt-icon-shape></yt-icon></div>

to this:

<div class="yt-spec-button-shape-next__icon" aria-hidden="true" style="margin-left:auto; margin-right:auto; display:block;"><yt-icon style="width: 24px; height: 24px;"><!--css-build:shady--><!--css-build:shady--><yt-icon-shape class="style-scope yt-icon"><icon-shape class="yt-spec-icon-shape"><div style="width: 100%; height: 100%; display: block; fill: currentcolor;"><svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24" focusable="false" style="pointer-events: none; display: inherit; width: 100%; height: 100%;"><path d="M15 5.63 20.66 12 15 18.37V14h-1c-3.96 0-7.14 1-9.75 3.09 1.84-4.07 5.11-6.4 9.89-7.1l.86-.13V5.63M14 3v6C6.22 10.13 3.11 15.33 2 21c2.78-3.97 6.44-6 12-6v6l8-9-8-9z"></path></svg></div></icon-shape></yt-icon-shape></yt-icon></div>

Download Button:

changed this:
<div class="yt-spec-button-shape-next__icon" aria-hidden="true"><yt-icon style="width: 24px; height: 24px;"><!--css-build:shady--><!--css-build:shady--><yt-icon-shape class="style-scope yt-icon"><icon-shape class="yt-spec-icon-shape"><div style="width: 100%; height: 100%; display: block; fill: currentcolor;"><svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24" focusable="false" style="pointer-events: none; display: inherit; width: 100%; height: 100%;"><path d="M17 18v1H6v-1h11zm-.5-6.6-.7-.7-3.8 3.7V4h-1v10.4l-3.8-3.8-.7.7 5 5 5-4.9z"></path></svg></div></icon-shape></yt-icon-shape></yt-icon></div>

to this:

<div class="yt-spec-button-shape-next__icon" aria-hidden="true" style="margin-left:auto; margin-right:auto; display:block;"><yt-icon style="width: 24px; height: 24px;"><!--css-build:shady--><!--css-build:shady--><yt-icon-shape class="style-scope yt-icon"><icon-shape class="yt-spec-icon-shape"><div style="width: 100%; height: 100%; display: block; fill: currentcolor;"><svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24" focusable="false" style="pointer-events: none; display: inherit; width: 100%; height: 100%;"><path d="M17 18v1H6v-1h11zm-.5-6.6-.7-.7-3.8 3.7V4h-1v10.4l-3.8-3.8-.7.7 5 5 5-4.9z"></path></svg></div></icon-shape></yt-icon-shape></yt-icon></div>

Super Thanks Button:

changed this:
<div class="yt-spec-button-shape-next__icon" aria-hidden="true"><yt-icon style="width: 24px; height: 24px;"><!--css-build:shady--><!--css-build:shady--><yt-icon-shape class="style-scope yt-icon"><icon-shape class="yt-spec-icon-shape"><div style="width: 100%; height: 100%; display: block; fill: currentcolor;"><svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24" focusable="false" style="pointer-events: none; display: inherit; width: 100%; height: 100%;"><path d="M11 17h2v-1h1c.55 0 1-.45 1-1v-3c0-.55-.45-1-1-1h-3v-1h4V8h-2V7h-2v1h-1c-.55 0-1 .45-1 1v3c0 .55.45 1 1 1h3v1H9v2h2v1zm5.5-15c-1.74 0-3.41.88-4.5 2.28C10.91 2.88 9.24 2 7.5 2 4.42 2 2 4.64 2 7.99c0 4.12 3.4 7.48 8.55 12.58L12 22l1.45-1.44C18.6 15.47 22 12.11 22 7.99 22 4.64 19.58 2 16.5 2zm-3.75 17.85-.75.74-.74-.73-.04-.04C6.27 14.92 3 11.69 3 7.99 3 5.19 4.98 3 7.5 3c1.4 0 2.79.71 3.71 1.89L12 5.9l.79-1.01C13.71 3.71 15.1 3 16.5 3 19.02 3 21 5.19 21 7.99c0 3.7-3.28 6.94-8.25 11.86z"></path></svg></div></icon-shape></yt-icon-shape></yt-icon></div>

to this:

<div class="yt-spec-button-shape-next__icon" aria-hidden="true" style="margin-left:auto; margin-right:auto; display:block;"><yt-icon style="width: 24px; height: 24px;"><!--css-build:shady--><!--css-build:shady--><yt-icon-shape class="style-scope yt-icon"><icon-shape class="yt-spec-icon-shape"><div style="width: 100%; height: 100%; display: block; fill: currentcolor;"><svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24" focusable="false" style="pointer-events: none; display: inherit; width: 100%; height: 100%;"><path d="M11 17h2v-1h1c.55 0 1-.45 1-1v-3c0-.55-.45-1-1-1h-3v-1h4V8h-2V7h-2v1h-1c-.55 0-1 .45-1 1v3c0 .55.45 1 1 1h3v1H9v2h2v1zm5.5-15c-1.74 0-3.41.88-4.5 2.28C10.91 2.88 9.24 2 7.5 2 4.42 2 2 4.64 2 7.99c0 4.12 3.4 7.48 8.55 12.58L12 22l1.45-1.44C18.6 15.47 22 12.11 22 7.99 22 4.64 19.58 2 16.5 2zm-3.75 17.85-.75.74-.74-.73-.04-.04C6.27 14.92 3 11.69 3 7.99 3 5.19 4.98 3 7.5 3c1.4 0 2.79.71 3.71 1.89L12 5.9l.79-1.01C13.71 3.71 15.1 3 16.5 3 19.02 3 21 5.19 21 7.99c0 3.7-3.28 6.94-8.25 11.86z"></path></svg></div></icon-shape></yt-icon-shape></yt-icon></div>
and so on.
heres a picutre of all the buttons i think i dont know anymore:

image

CatsArmy avatar Jun 24 '24 10:06 CatsArmy

Hi, I would like to be assigned to this issue. Are there any prerequisites?

mnyamunda-scottlogic avatar Jun 24 '24 16:06 mnyamunda-scottlogic

No idea but should be pretty easy as it happens when it removes the text from the icons I'll take a look maybe

Should be a simple one depending on how this extensions works and how YouTube works

I'm not too familiar with it

CatsArmy avatar Jun 24 '24 18:06 CatsArmy

i think it should be somewhere near this part of the code

CatsArmy avatar Jun 24 '24 19:06 CatsArmy

https://github.com/code-charity/youtube/blob/26eb6078f2cd0193ececacc40be45cb69138c2ac/js%26css/extension/www.youtube.com/appearance/details/details.css#L15

ImprovedTube avatar Jun 25 '24 03:06 ImprovedTube

Thanks folks, will work on this :)

mnyamunda-scottlogic avatar Jun 27 '24 09:06 mnyamunda-scottlogic

Hey folks I have located the 5 buttons that need to be centred.

  • Share
  • Download
  • Super Thanks
  • Clip
  • Playlist

Are there some instructions to get a development version of the extension running on my YouTube so I can visually confirm that my code is working? readmes etc

Thanks! :)

mnyamunda-scottlogic avatar Jun 27 '24 10:06 mnyamunda-scottlogic