youtube icon indicating copy to clipboard operation
youtube copied to clipboard

enlarge(/boost/magnify/increase) youtube's volume slider

Open obeydesign opened this issue 1 year ago • 12 comments

PROBLEM: I'm frustrated by the inability to boost volume on videos. The Forced Volume option under Player has the strange behavior of setting all volume controls on newly opened YouTube videos to maximum, then, I guess, some volume amplification is done in the background.

SOLUTION:
The behavior I expect is to have the volume slider on newly opened players be where I set it last, and to have the volume boost added to that level, not to set the slider to maximum, then amp up the volume from there.

RELEVANCE / SCOPE: I claim this affects all users.

"SIDE EFFECTS":
No conflicts.

CONTEXT: Thank you!

SHORT Table (Summary)
Problem Unexpected behavior from the Forced Volume option
Solution Change behavior to not automatically set a new player's volume slider to 100%
Alternatives
Scope
Side effects
Context Every newly opened video player

obeydesign avatar Mar 23 '24 18:03 obeydesign

Would you feel better if the slider still displayed whatever volume you have set now while video played louder? What purpose would the slider at lets say for example 30% have in that case?

Lower volume sound samples carry less data. Yes, its possible to leave volume low and apply gain on that low volume signal, but it will sound terrible.

raszpl avatar Mar 25 '24 06:03 raszpl

I’m going to say:

  1. if the player volume slider is set to 100, the plug-in should play the audio at 200%—I don’t know if this is possible, I’m just setting up a scenario
  2. If the plug-in is set to automatically amplify audio, and the YouTube player is set to 50%, I would expect the output to be 100%.
  3. If the plug-in is set to automatically amplify audio, and the YouTube player is set to 30%, I would expect the output to be around 70%.

I work in UX, but haven’t worked on this specific situation before. I also don’t know, from a technical standpoint, how your plug-in—for which I thank the stars every day I use it—works with audio.

On Mar 25, 2024, at 1:19 AM, Rasz_pl @.***> wrote:

Would you feel better if the slider still displayed whatever volume you have set now while video played louder? What purpose would the slider at lets say for example 30% have in that case?

Lover volume sound samples carry less data. Yes, its possible to leave volume low and apply gain on that low volume signal, but it will sound terrible.

— Reply to this email directly, view it on GitHub https://github.com/code-charity/youtube/issues/2116#issuecomment-2017305412, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUUL3PFDWHQKGJRC6DWIDLYZ66XBAVCNFSM6AAAAABFE2UM6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGMYDKNBRGI. You are receiving this because you authored the thread.

obeydesign avatar Mar 25 '24 23:03 obeydesign

Took me a good couple of days, buy I got there eventually! I finally understand what you are talking about, a general "boost my crappy speakers by x" software toggle. Pretend the new 150% volume is just 30% etc. Instead of 0-400% "Forced volume" we can let User directly set separate "Volume Gain" multiplier and figure out logistics under the hood by faking YT player volume slider reading and switching between no gain and gain at appropriate levels. Yes, this makes sense and is much more user friendly.

The way it currently works is anything up to 100% is pure volume, above we use AudioContext createGain() https://github.com/code-charity/youtube/blob/f935ebf554aaa735b092d9a1cf01e72a1b09a7d0/js%26css/web-accessible/www.youtube.com/player.js#L530-L548 but the way its crudely implemented it will always start by displaying 100% and lowering the slider down ends up Amplifying bad signal with bad signal to noise ratio by whatever ratio set by "Volume Gain"/100 :/

raszpl avatar Mar 26 '24 01:03 raszpl

The solution is obvious. Buy YouTube and make it better. Sent from my iPhoneOn Mar 25, 2024, at 8:39 PM, Rasz_pl @.***> wrote: Took me a good couple of days, buy I got there eventually! I finally understand what you are talking about, a general "boost my crappy speakers by x" software toggle. Pretend the new 150% volume is just 30% etc. Instead of 0-400% "Forced volume" we can let User directly set separate "Volume Gain" multiplier and figure out logistics under the hood by faking YT player volume slider reading and switching between no gain and gain at appropriate levels. Yes, this makes sense and is much more user friendly. The way it currently works is anything up to 100% is pure volume, above we use AudioContext createGain() https://github.com/code-charity/youtube/blob/f935ebf554aaa735b092d9a1cf01e72a1b09a7d0/js%26css/web-accessible/www.youtube.com/player.js#L530-L548 but the way its crudely implemented it will always start by displaying 100% and lowering the slider down ends up Amplifying bad signal with bad signal to noise ratio by whatever ratio set by "Volume Gain"/100 :/

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

obeydesign avatar Mar 26 '24 01:03 obeydesign

hi @obeydesign!

Forced Volume .. behavior

  1. our feature originally was just to permanently force the same volume level for every video between 0 and 100. So most people have it set below 100. (And we or you can rename or annotate to explain that accordingly! 🎉 )

  2. New feature: Boost youtube's volume slider: We can edit youtube's volume slider's maximum! By allowing to move the handle further, but making it appear gradually red when reaching increasingly questionable Level/method.

  • (Unfortunately this will either have to appear transparent above the playback timer - or video time or shift it to the right. When i first wrote this it was a vertical slider (like window's, and not horizontal like android and chrome-book)

  • planned-out here

  • Fortunately tweaks of the youtube player might last longer and are more relevant than the rest of the youtube page.

  • As of youtube's volume normalization there usually should be some more loss-less gain possible @raszpl

  • ..and some people might be used to a temporary shortcut key (or button #1981) to undo (toggle-off) that we would have to reverse the calculation or store the previous value.

ImprovedTube avatar Mar 26 '24 07:03 ImprovedTube

I was thinking...always a bad idea...what if instead of "volume booster," it was a "volume magnifier," which would, by percentage, increase the volume of the YouTube player setting?

On Tue, Mar 26, 2024 at 2:02 AM ImprovedTube @.***> wrote:

hi @obeydesign https://github.com/obeydesign!

Forced Volume .. behavior

our feature originally was just to permanently force the same volume level for every video between 0 and 100. So most people have it set below 100. (And we or you can rename or annotate to explain that accordingly! 🎉 )

New feature: Boost youtube's volume slider: We can edit youtube's volume slider's maximum! By allowing to move the handle further, but making it appear gradually red when reaching increasingly questionable Level/method.

(Unfortunately this will either have to appear transparent above the playback timer - or video time or shift it to the right. When i first wrote this it was a vertical slider (like window's, and not horizontal like android and chrome-book)

planned-out here https://github.com/code-charity/youtube/issues/1445#:~:text=1)Plan%202)better%20global%20addon

Fortunately tweaks of the youtube player might last longer and are more relevant than the rest of the youtube page.

As of youtube's volume normalization there usually should be some more loss-less gain https://github.com/code-charity/youtube/issues/1445#:~:text=3)combine%20with%20normalization%23comment%20(%20max.%20gain%23comment%20) possible @raszpl https://github.com/raszpl

— Reply to this email directly, view it on GitHub https://github.com/code-charity/youtube/issues/2116#issuecomment-2019527762, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUUL3OWQ25F3MQTMFPC7NTY2EFOXAVCNFSM6AAAAABFE2UM6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJZGUZDONZWGI . You are receiving this because you were mentioned.Message ID: @.***>

obeydesign avatar Mar 26 '24 07:03 obeydesign

Without touching the size of Youtube's volume slider, we should still mark up/remind of the boosted somehow with a sticky position in the middle, visual divider marking 100%, and a light red color above that.

ImprovedTube avatar Mar 26 '24 07:03 ImprovedTube

I agree.

On Mar 26, 2024, at 2:11 AM, ImprovedTube @.***> wrote:

Without touching the size of Youtube's volume slider, we should still mark up/remind of the boosted somehow with a sticky position in the middle, visual divider marking 100%, and a light red color above that.

— Reply to this email directly, view it on GitHub https://github.com/code-charity/youtube/issues/2116#issuecomment-2019538278, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUUL3OSJ6BI6OB2KLLQ6IDY2EGQ7AVCNFSM6AAAAABFE2UM6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJZGUZTQMRXHA. You are receiving this because you were mentioned.

obeydesign avatar Mar 26 '24 07:03 obeydesign

Thank you

On Tuesday, March 26, 2024, ImprovedTube @.***> wrote:

Without touching the size of Youtube's volume slider, we should still mark up/remind of the boosted somehow with a sticky position in the middle, visual divider marking 100%, and a light red color above that.

— Reply to this email directly, view it on GitHub https://github.com/code-charity/youtube/issues/2116#issuecomment-2019538278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZIQEUVWFEH7FHNB3EYKNILY2EGS3AVCNFSM6AAAAABFE2UM6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJZGUZTQMRXHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

suparnaghosh934 avatar Mar 26 '24 07:03 suparnaghosh934

work in UX

then chances are you will stay @obeydesign 😃. As this project is unique there and a lot of this github yet is(/should be) about #UX & #UI discussions . While features are specific and some are just [too] little tweaks, yet will otherwise be worth it to up to all youtube users. (and thus should be set & forget, as far as we have the dev-capacity) )


You'd probably enjoy at the top of our To-Do-List to simply allow everyone to enable/disable all of youtube's experiment flags (up to 800?) - (and crowdsourcing what they even mean)

= We can allow users to enable / disable so much more and easier than we did yet. So features should be ranked and to many users the most important sections would be Youtube added/changed recently "what i removed" & "what i added" https://docs.google.com/spreadsheets/d/1GidvMduxTl6jXpDCKj-sOPg8KSqDfCYO2OlCdBADaSI/edit?pli=1#gid=0

Long-term structure/vision for our UI:

  1. my content & discovery logic

  2. my~?setup:
    a) (Web-)Video Features (+specific Youtube Tweaking + Youtube's Experiment Flags , those added by the user) ). b) Youtube: Cleaning/Trashbin (Up to 100s (including disabled Youtube's Experiment Flags) Ideally needed decreasingly often.) c) Youtube Minimap/Layout (more sections, maybe Drag&drop for Sizes, Positions & paint bucket for Colors)

( https://github.com/code-charity/youtube/discussions/848#discussioncomment-588359, https://github.com/code-charity/youtube/issues/890#issuecomment-1034264001 )

while extra exceptions/conditions like video genre could be set for many features on right click. and shortcuts or buttons to toggle any experiment flag or anything could be setup with right click too.


furthermore we could cover 2,3,4 dimensional settings "rule builders" (doing something only if multiple conditions are met) example: https://github.com/code-charity/youtube/issues/2042#issuecomment-2015267884. like: https://chromewebstore.google.com/detail/youtube-refined/bhbammekghlcjhbiekoldhpfgelblcni and so much more (even if not every users will find them easy or ever learn about the power of such, we could crowd-source such rules ) https://github.com/code-charity/youtube/discussions/1881#discussioncomment-7820498 https://github.com/code-charity/youtube/discussions/1881#discussioncomment-8912041 )

ImprovedTube avatar Mar 26 '24 08:03 ImprovedTube

(related: https://github.com/code-charity/youtube/issues/324 )

ImprovedTube avatar Mar 26 '24 11:03 ImprovedTube

chances are you will stay @obeydesign 😃. As this project is unique there and a lot of this github yet is(/should be) about #UX & #UI discussions . While features are specific and some are just [too] little tweaks, yet will otherwise be worth it to up to all youtube users. (and thus should be set & forget, as far as we have the dev-capacity) )

(funny but true example: https://github.com/code-charity/youtube/issues/1818 )

ImprovedTube avatar Mar 26 '24 18:03 ImprovedTube

Still waiting for this, Enhancer for YouTube already has it

GKid94 avatar Dec 12 '24 14:12 GKid94