review our shortcut logic. (bug: screenshot by shortcut might takes several screenshots unintentionally; etc: ... #1565)

[ImprovedTube]

might be easy considering the relevance.

https://github.com/code-charity/youtube/blob/master/js%26css/web-accessible/www.youtube.com/shortcuts.js

[0scvr]

Is this bug still present ? If not , I would be willing to take a look.

[ImprovedTube]

hi! @0scvr wow, that would be great! regret i missed it!!

https://github.com/code-charity/youtube/issues/1565

[0scvr]

I've tested this bug locally and I do not have this issue. When pressing the shortcut for a short time and immediately releasing the keys, only 1 image is downloaded. If I stay pressed for longer though, multiple images will be downloaded. I think this is working correctly, no?

[ImprovedTube]

hi @0scvr, yes, admittedly it was bad only when is used a bit worn down key and a fast CPU.

• However some of the screenshots will easily be the same frame... (=bad*)

maybe faster than the rate set in the OS for repeating through holding (which might be a hint, that there might be bad loop in the code. And the same logic applies to all our shortcuts, which makes it relevant / exciting https://github.com/code-charity/youtube/issues/1565 )

---

( if a user ever wanted to screenshot every frame, this could be done while the video is paused. While every hit of the shortcut could also skip the current frame (just like our https://github.com/code-charity/frame-by-frame) )

[0scvr]

I don't think I'm the person for this issue, sorry.

[raszpl]

Imo a non issue. Everything is working correctly, shortcuts are triggered at the rate of keyboard events coming in. Imo adding artificial delays (lowers responsiveness) just in case someone could have broken keyboard is a bad idea.