code-charity
can you please assign a key to the rotate video option ?
Assigning a button to rotate each time by 90?
In your opinion which would be the correct key to assign?
There are vertical videos on YouTube which are uploaded horizontally. "R" key would do.
There are vertical videos on YouTube which are uploaded horizontally. "R" key would do.
I understand, but I feel like the button is alright for the rotation since it's a pretty niche function. I just came across issue #1566 and there's plans for removing all key binds because of their poor UX (hidden tooltips, think of iPhone's 3D Touch) and undesired behavior.
Maybe we could make an exception for the rotation, but how many users are going to benefit from it? Who's going to use it? Imagine someone clicking 'R' accidentally, then needs to understand which button performed the rotation by random clicking each key. Finally he would rotate the video with its dedicated icon or just reload the window.
Even the users who mostly see these "rotated" videos, how would they know 'R' is to rotate? The User-Experience is overall bad; there are more downsides than upsides.
There could be an option to disable/enable the shortcut keys then and they could be disabled by default. Only those who want to use shortcut keys could use them. "R" or "Shift+R" if people might press 'R' accidentally.
- to prepare the option to set any custom shortcut, we mainly only need to add a menu item and call the same function that our rotate button will call on click.
web-accessible/shortcuts.js- since the function is only defined on-click function, we can copy & paste it to the shortcut.
line: https://github.com/code-charity/youtube/blob/9266d8dfe76eaec30936b4efffcfe931c3c60337/js%26css/web-accessible/www.youtube.com/player.js#L773-L792
(or come up with another way to save both, the duplicate lines but also only define the function on click or press of button (not needed otherwise))
- since the function is only defined on-click function, we can copy & paste it to the shortcut.
@dante987 @D-Rekk
More on shortcuts: #1565
there's plans for removing all key binds because of their poor UX
( automatically will be easy if we do #1565 anyways, else it could be a manual feature as few things are true for all users and we do nothing/little by default)
