youtube icon indicating copy to clipboard operation
youtube copied to clipboard

Expanded descriptions not working

Open ebyrne242 opened this issue 3 years ago • 1 comments

Bug Report:

BUG: Setting description to expanded doesn't expand the description.

HOW: Set Appearance -> Details -> Description to Expanded. Visit any video, descriptions are never expanded.

EXPECTED (/preferred) behavior: description is auto-expanded so you don't have to click "more".

Screenshots:
image

Setup:

⚬ ImprovedTube Version: 3.946 ⚬ Browser: Chrome 104.0.5112.101 (Official Build) (64-bit) ⚬ Settings:
{"description":"expanded","ga":1661576220192,"header_improve_logo":false,"how_long_ago_the_video_was_uploaded":false,"theme":"dark"} ⚬ OS: Linux, Fedora 36

ebyrne242 avatar Aug 27 '22 05:08 ebyrne242

Based on the setting you given, I did not see that you enable Expanded for Description. It should have "description":"expanded"

dodieboy avatar Sep 09 '22 05:09 dodieboy

@sketch242 welcome! :) doesnt work indeed. just wonder why nobody else reported this

ImprovedTube avatar Sep 29 '22 15:09 ImprovedTube

  • is going to youtube's previous design a fix still? https://github.com/code-for-charity/YouTube-Extension/issues/980#issuecomment-898933927

  • we only need to add this CSS when the feature is enabled, no?


  • the feature's position in our menu also should be moved up again to the appearance-minimap https://github.com/code-for-charity/YouTube-Extension/issues/1429

ImprovedTube avatar Sep 29 '22 15:09 ImprovedTube

thanks @ebyrne242

ImprovedTube avatar Mar 17 '23 11:03 ImprovedTube

Same here Description>Expanded very often not working. ImprovedTube Version: 4.443 It's not working on every new tab (on current or new tab).

image

It works however after refreshing current tab, but when I go directly to some other video, the description doesn't show again. Page source: https://gist.github.com/xeophyte/9b03111457cd6967b1598eb2f183baa5 ImprovedTube settings: improvedtube.json

xeophyte avatar Dec 06 '23 12:12 xeophyte

hi @xeophyte made the feature click the description a second time after 7 seconds!

ImprovedTube avatar Dec 07 '23 00:12 ImprovedTube

I do not know what it means ;]

xeophyte avatar Dec 07 '23 11:12 xeophyte

hi @xeophyte, it always "clicks" the description (=expand) 0.3s after observing changes with the description. For now i made all these clicks repeat after 7s. Please try if this timing helps to cover all your tabs. This is for testing (not impossible that somebody clicks "show less" as fast as possible and then wonders what happens)

else we could also just repeat running a list of our feature on focus (=when a tab becomes active) (- if there is no easy explanation and more elegant way)

ImprovedTube avatar Dec 07 '23 15:12 ImprovedTube

I'm not sure if I understood, but for me expanding the description after 7 seconds is definitely too late. It should expand immediately after loading each page or immediately after activating (navigating to) a given tab.

xeophyte avatar Dec 07 '23 18:12 xeophyte

hi @xeophyte, you can still try if it is a remedy at all for the bug you got or no.
( + seems unlikely that you will want a tab in the background only for a few seconds)

ImprovedTube avatar Dec 11 '23 02:12 ImprovedTube

hi! @xeophyte did you try with the new version?

ImprovedTube avatar Jan 05 '24 22:01 ImprovedTube

hi! @xeophyte did you try with the new version?

On 4.583 I think it's still the same. YT videos opened in the same tab (like from related or next from playlist) opens without description expanded. It only expands when I refresh the current page or open some YT tab in the background (new YT tab already got expanded description).

xeophyte avatar Jan 06 '24 20:01 xeophyte

hi @xeophyte please try v4.644+

ImprovedTube avatar Feb 20 '24 06:02 ImprovedTube

hi @xeophyte please try v4.644+

There is no such version https://github.com/code-charity/youtube/releases

xeophyte avatar Feb 20 '24 11:02 xeophyte

Looks like fixed for me in 4.704.

xeophyte avatar Mar 04 '24 17:03 xeophyte