youtube icon indicating copy to clipboard operation
youtube copied to clipboard

To be more prominent:"my activated features" + Naming:"unlimited page width (no side margin)"

Open jennycolvin opened this issue 3 years ago • 4 comments

BUG: in Firefox, the player behaves strangely when ImproveTube is enabled: it's bigger than it should be, looking like it's extended on the right side, with the timeline bar not covering the entire video as usual. Also, the thumbnail is not displayed properly. Crosschecking with Chrome, I cannot reproduce the issue there. I've also gone the usual step - disabling every extension I have to check if any of them was the culprit. Disabling ImprovedTube is the only way for me to resolve the problem.

HOW: Open any video in Firefox.

EXPECTED (/preferred) behavior: the player should maintain its proper size and the thumbnail should be displayed properly.

Screenshots:
ImprovedTube Enabled: https://tinypic.host/images/2022/01/31/improvedtube_active.jpg

ImprovedTube Disabled: https://tinypic.host/images/2022/01/31/improvedtube_inactive.jpg

/ ⚬ Context: This behavior started with version 3.935. Probably some conflicts with Firefox's latest versions?

Setup:

⚬ ImprovedTube Version: 3.935 ⚬ Browser: Firefox 96.0.3 (and previous versions, since updating to ImprovedTube 3.935) ⚬ Settings: {"add_scroll_to_top":true,"blacklist_activate":true,"channel_trailer_autoplay":false,"channel_videos_count":false,"forced_theater_mode":false,"how_long_ago_the_video_was_uploaded":true,"language":"en","limit_page_width":false,"mark_watched_videos":true,"player_ads":"block_all","player_autoplay":false,"player_h264":false,"player_popup_button":true,"player_quality":"auto","player_repeat_button":true,"player_screenshot_button":true,"player_screenshot_save_as":"file","player_size":"do_not_change","player_subtitles":false,"playlist_autoplay":false,"playlist_repeat":true,"playlist_up_next_autoplay":false,"red_dislike_button":true,"theme":"dark","up_next_autoplay":false} ⚬ OS: Windows 10 ⚬ Device:

jennycolvin avatar Jan 31 '22 10:01 jennycolvin

Welcome @jennycolvin

  • please check your list of activated features inside ImprovedTube. Probably there you see, that 'Limit page width' is off? This feature is new. Enable the switch to restore youtube's Limit (and the feature will be gone from your list the next time you click it). Of course for our new users, thinking of Youtube, a better name will be be 'don't limit page width' so that the switch is indicating when Improvedtube does something (just technically this is something we disable and on the other hand its more simple with fewer words)

    • [x] Luckily this question is totally unneccessary, since we can also just name it: 'unlimited page width (no side margin)'
  • And we can move it from general to player: size. Or better show it in both places, since it fits both (- and restructure our whole menu: https://github.com/code4charity/YouTube-Extension/discussions/748 )

ImprovedTube avatar Jan 31 '22 22:01 ImprovedTube

You were spot on. I noticed the new feature, but I left it turned off exactly because it says "Limit page width" - I interpreted that as to mean something regarding theatre mode, and since I usually use it on my secondary screen (which is smaller than my main one), so I can see better I didn't think turning it on would be wise. Anyway, I enabled it and so far so good. One thing, though: the feature is still there in my list - refreshed the page and restarted Firefox did not change its presence.

jennycolvin avatar Feb 01 '22 00:02 jennycolvin

Yes, we should rename it/change the switch. very attentive that you notice whats new. 🤩 We know no bugs with 'active features' 🤔 Should be on the front page though & could be more intuitive? Works in firefox 96, windows 10 & your settings.

ImprovedTube avatar Feb 01 '22 05:02 ImprovedTube

If I may? Yes, it could be more intuitive. Others may make the same mistake I did. Or maybe a tooltip explaining how the function work, if at all possible?

jennycolvin avatar Feb 01 '22 09:02 jennycolvin