code-charity
Extension Instant Search & Completition
1. Our search in the extension:
-
[ ] To implement functional search the least we got to cover is Synonyms/Tags & language/s (either all languages or at least english + the one the users set https://github.com/code-for-charity/YouTube-Extension/discussions/748 )
-
[ ] Possibly with a 3rd party JS/indexDB search lib. While "overpowered here, it wont harm & we should learn the most performant one anyways for History Manager https://github.com/code-for-charity/History-Manager-with-indexedDB (instead of reinventing this wheel) ( inspiration: https://github.com/nextapps-de/bulksearch - or the most actively developed one today....) (please test History manager!)
2. bugs:
- [ ] bug: doesnt find any string with spaces..
didnt happen before: https://github.com/code-for-charity/SATUS/issues/3 :
- [x] instant search is missing (=focus on the input )
( why? @victor-savinov ) - [ ] now also: bug in satus.js with marking text in all ~inputs~ text areas (ctrl+a)
always happened:
- [ ] Not focused to react to keys when going back to home screen - could also be active on all screens (except when setting hotkeys) ( refers to version: https://github.com/code-for-charity/YouTube-Extension/releases/tag/v3.900 )
- [ ] of course it should also react to key in the sub folder, and show each folder's results on top, before other results
@ImprovedTube I see the problem now, thanks for updating the report. It looks like this is an issue with @victor-savinov's Satus library. The version in the ImprovedTube repo is minified so its missing all the readable variable names which makes it hard to understand. @victor-savinov Doesn't have the none-minified version uploaded anywhere so I can't really fix it.
In the future it would be better to have the un-minified version in the repo and just have the minification built into the build script for quicker development.
@ImprovedTube Also I don't think there exists a bug that is not already an existing feature, so no real use to adding the feature exists label to bugs it should be used for feature requests where the feature exists in another form (such as a feature that exists in another extension)
Satus
Exactly! Firefox also requires source / unminified.
@hboyd2003 https://github.com/code-for-charity/YouTube-Extension/blob/v4.0/assets/satus/satus.js
i dont recall adding feature exists :D