Results 777 comments of Asher

Oh! Interesting, I missed that line. I did not realize Axios had its own proxy. Yeah disabling it in favor of our own makes sense to me. Thank you for...

If this is also broken in Codespaces then please report it upstream since it will need to be fixed in VS Code itself! https://github.com/microsoft/vscode

Thank you for opening that issue! I will go ahead and close this one.

This is probably OK, but something about letting things through the proxy to the app without auth is making me nervous. Would it work if we just respond with a...

Also thank you for working on this!

And I suppose we will need to do the same for the path-based proxy.

Actually, I suppose we have to let it through because it could be a 404 or something else, no way to know for sure that particular preflight will actually be...

Sorry to keep going back and forth :sweat_smile: But I was thinking if we do pass it through, that exposes information (which ports have things on them) and maybe we...

> hardcoding 204 kind of defeats the purpose of preflighting requests Yeah, you are right, but the attack surface is large since we automatically forward every port, so it makes...