django-mailbox icon indicating copy to clipboard operation
django-mailbox copied to clipboard

compatibility w django 4.0

Open sanderroosendaal opened this issue 3 years ago • 5 comments

sanderroosendaal avatar Dec 16 '21 13:12 sanderroosendaal

To achieve Django 4.0 compatibility it is required to at least:

  • update classifiers in setup.py
  • update CI to tests on Django 4.0
  • update docs to mark Django 4.0 compatibility
  • verify if there is any pending migrations
  • update release note to mark Django 4.0
  • fix any failing tests after CI update

This is additional work (going beyond the original problem, but falling within the scope of the PR title), but it will ensure that there are no other problems and you will not have to come back.

ad-m avatar Dec 16 '21 14:12 ad-m

To achieve Django 4.0 compatibility it is required to at least:

  • update classifiers in setup.py
  • update CI to tests on Django 4.0
  • update docs to mark Django 4.0 compatibility
  • verify if there is any pending migrations
  • update release note to mark Django 4.0
  • fix any failing tests after CI update

This is additional work (going beyond the original problem, but falling within the scope of the PR title), but it will ensure that there are no other problems and you will not have to come back.

I completely understand and agree. However, I am not able to invest time to get up to speed with how this library works. I was just a happy user, but I have also found that I am having less and less use for it in my project. In fact, I can remove django-mailbox from my project in about an hour of work, including testing. So, the rational choice for me is to do that, although I hate to leave the work to the django-mailbox team. Thanks for years of use without issues!

sanderroosendaal avatar Dec 17 '21 08:12 sanderroosendaal

Hi, is this still alive ? I would need this functionality, and I just wanted to ask if the project will be maintained.

Thanks a lot.

ghost avatar Jun 28 '22 09:06 ghost

Hi, @janetatomas11. Could you simply use the PR in your project? I don't have write permission here, so I won't be able to help. However, I made local changes to make it work on my Django 4 project. It seems the changes I made are present in this PR.

Haakonoeyen avatar Jun 28 '22 20:06 Haakonoeyen

Thanks.

ghost avatar Jun 29 '22 14:06 ghost

@coddingtonbear Could you please merge this? Now library incompatible with Django 4.1, cannot use it for the new projects.

eugapx avatar Mar 13 '23 18:03 eugapx

I wish I could, @eugapx, but as discussed here: https://github.com/coddingtonbear/django-mailbox/pull/253#issuecomment-1329509623 I need some contributors to take some time to vet these changes (or the ones in the other PR referenced there).

coddingtonbear avatar Mar 13 '23 23:03 coddingtonbear