django-mailbox icon indicating copy to clipboard operation
django-mailbox copied to clipboard

Error when upgrading to Django 4.0

Open sanderroosendaal opened this issue 3 years ago • 6 comments

File "/home/sander/python/rowsandall/venv/lib/python3.8/site-packages/django_mailbox/models.py", line 31, in from django_mailbox.signals import message_received File "/home/sander/python/rowsandall/venv/lib/python3.8/site-packages/django_mailbox/signals.py", line 3, in message_received = Signal(providing_args=['message']) TypeError: init() got an unexpected keyword argument 'providing_args'

sanderroosendaal avatar Dec 16 '21 09:12 sanderroosendaal

It's deprecated and we don't released yet version for Django 4.0. Could you provide PR for that?

ad-m avatar Dec 16 '21 11:12 ad-m

This solved the problem for me.

In C:\Users\USERNAME.virtualenvs\autotek-a3gt69_I\lib\site-packages\django_mailbox\signals.py

Simply change message_received = Signal(providing_args=['message']) to message_received = Signal()

Haakonoeyen avatar Dec 18 '21 08:12 Haakonoeyen

@Haakonoeyen there is PR for that #249 . Do you like take over it to make a new version of django-mailbox happen?

ad-m avatar Dec 18 '21 10:12 ad-m

I'd love to, but I'm new to github so I'm gonna need a little help getting started. What will I have to do?

Haakonoeyen avatar Dec 18 '21 19:12 Haakonoeyen

@Haakonoeyen you need pull locally pull request #249 (see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally ), prepare outlined changes and create a new pull request ( https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request ) with all required changes. I think from a code perspective, these changes are minimal, so it's a perfect case to start working with open-source on GitHub

See also https://github.com/firstcontributions/first-contributions and https://opensource.guide/how-to-contribute/ .

ad-m avatar Dec 18 '21 19:12 ad-m

@ad-m I would like to know if you have an upcoming date to release support for Django 4

humbertolopezleon avatar Jun 03 '22 20:06 humbertolopezleon

@ad-m I would like to know if you have an upcoming date to release support for Django 4

Version 4.9.0 with Django 4 support has been released

Pietro395 avatar Dec 10 '23 22:12 Pietro395