codalab-competitions icon indicating copy to clipboard operation
codalab-competitions copied to clipboard

Feature/add rabbitmq consumer timeout and fix http proxy support for django

Open dtuantran opened this issue 2 years ago • 3 comments

@Didayolo or @bbearce or @ihsan

Add consumer_timeout into rabbitmq config in order to overwrite default value. Add http proxy support for codalab

A checklist for hand testing

  • [x] recreate Codalab with no WORKER_CONNECTION_TIMEOUT value in .env (without variables of HTTP_PROXY, HTTPS_PROXY, NO_PROXY)
  • [x] recreate Codalab with a WORKER_CONNECTION_TIMEOUT value in .env (without variables of HTTP_PROXY, HTTPS_PROXY, NO_PROXY)
  • [x] recreate Codalab with HTTP_PROXY, HTTPS_PROXY and NO_PROXY variables (already done on production)

Checklist

  • [x] Code review by me
  • [x] Hand tested by me
  • [x] I'm proud of my work
  • [ ] Code review by reviewer
  • [ ] Hand tested by reviewer
  • [ ] CircleCi tests are passing
  • [ ] Ready to merge

dtuantran avatar Dec 21 '23 15:12 dtuantran

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6901945) 60.38% compared to head (4689e35) 60.38%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3455   +/-   ##
========================================
  Coverage    60.38%   60.38%           
========================================
  Files          173      173           
  Lines        11411    11411           
========================================
  Hits          6891     6891           
  Misses        4520     4520           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 21 '23 15:12 codecov-commenter

If you are running Docker 5.20, you need to upgrade to 5.24 in order to run apply this changes.

dtuantran avatar Dec 21 '23 17:12 dtuantran

Shouldn't this come with changes in docker-compose.yml, so the containers access the new environment variables HTTP_PROXY and HTTPS_PROXY?

Didayolo avatar Jan 18 '24 15:01 Didayolo