[CY-5317] Uploading the coverage reports fails silently

[koenighotze]

No error is reported, if curl fails during the report upload. The workflow still continues as if the action succeeded.

I suggest do either drop at least an error message ("Upload failed because of: XYZ"), or add a configuration parameter fail_on_error to the action itself.

The curl errors are swallowed here, because of the -s flag to curl.

bash <(curl -Ls https://raw.githubusercontent.com/codacy/codacy-coverage-reporter/master/get.sh) report $auth $params --partial &&\
bash <(curl -Ls https://raw.githubusercontent.com/codacy/codacy-coverage-reporter/master/get.sh) final $auth

[github-actions[bot]]

Internal ticket created : CY-5317

[bmulholland]

This isn't the first "fails silently" bug I've seen with Codacy (also seen with eslint, rubocop, and brakeman all failing silently). It seems to be an issue in every part of the product. Can I suggest that this be raised as a priority internally? How will we ever trust that Codacy is working if it could be failing without us knowing at any time?