cocos2d-x-3rd-party-libs-bin icon indicating copy to clipboard operation
cocos2d-x-3rd-party-libs-bin copied to clipboard

A libflatbuffers is build inside 3rd party bins?

Open martell opened this issue 9 years ago • 4 comments

Can we move this to 3rd party source instead I have submitted a PR to google/flatbuffers with a patch to do just this you guys are welcome to use that patch in 3rd party source repo

https://github.com/google/flatbuffers/pull/238

@ricardoquesada Hi.

I'm trying to rebuild 3.7 for the new msys2 release and having source in 3rd party bins is causing issues again :D

martell avatar Jul 22 '15 12:07 martell

The google maintainer of the google/flatbuffers project has merged my PR. So with the next release version cocos2d-x should no longer need have a custom binary blob where as there will be an official libflatbuffers

martell avatar Jul 26 '15 12:07 martell

@martell Good job :+1:

zilongshanren avatar Jul 26 '15 12:07 zilongshanren

+1 for moving flatbuffers to src. @minggo @pandamicro do you know why it is in bin?

ricardoquesada avatar Jul 30 '15 21:07 ricardoquesada

I'm not sure why it's in bin, it's originally integrated by Beijing studio team, @chengstory @geron-cn @xiaofeng11 Maybe you guys know something ?

pandamicro avatar Jul 31 '15 05:07 pandamicro