cocos2d-html5 Fix reschedule issue with same callback

Fix reschedule issue with same callback

Open Dimon4eg opened this issue 7 years ago • 5 comments

The issue:

create timer with some repeat count cc.director.getScheduler().schedule(callback, target, interval, repeat, delay, paused, key);
wait for last repeat executed
in timer callback reschedule it again with the same callback
as result timer is broken and will never be executed

Reason: When we reschedule timer again from callback the scheduler just updates interval value: timer._interval = interval;

After callback executed timer will be canceled:

if (this._callback && !this._runForever && this._timesExecuted > this._repeat)
     this.cancel();

Fix: Scheduler will update interval only for not exhausted timers (still running). In our case, it will create new internal timer object and old one will be canceled after callback.