cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

Fix ASTC textures were not displayed correctly on some devices.

Open yoki0805 opened this issue 1 year ago • 3 comments

Device: Lenovo Tab M10 FHD Plus Chip: MediaTek Helio P22T (MT8768T) Platform: Web-mobile

Unable to display ASTC textures correctly. Screenshot_2024-10-24-14-31-58-549

After the fix. Screenshot_2024-10-24-14-34-43-124

Test demo: astc-test.zip

Reproduction steps:

  1. A specific device is required.
  2. Use non-power-of-two ASTC textures.
  3. Build the project.
  4. Run on the device.

Changelog


Continuous Integration

This pull request:

  • [ ] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

yoki0805 avatar Oct 22 '24 07:10 yoki0805

⚠️ Package size ⤴ 190 bytes, old: 5445998, new: 5446188

Interface Check Report

This pull request does not change any public interfaces !

github-actions[bot] avatar Oct 22 '24 08:10 github-actions[bot]

This demo only tested cases with Texture_2D & Cube_Map, I wasn't able to test cases with Texture_2D_Array & Texture_3D. Should the isFullCopy check also be applied to Texture_2D_Array & Texture_3D?

yoki0805 avatar Oct 24 '24 06:10 yoki0805

Thanks for your pr! We will investigate this issue.

star-e avatar Oct 25 '24 06:10 star-e

Have any plan? @star-e

yoki0805 avatar Nov 22 '24 03:11 yoki0805

Thanks for your pr. @yoki0805 We have created an issue to track this problem. The fix in this pr is good, but we have to test it on various platforms. So it takes some time to incorporate the fix.

star-e avatar Nov 22 '24 03:11 star-e

Got it, thank you!

yoki0805 avatar Nov 22 '24 03:11 yoki0805