cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

revert Node setter behavior as v3.8.3

Open minggo opened this issue 1 year ago • 3 comments

Changelog

  • The setter is imported by solving the issue: https://github.com/cocos/cocos-engine/issues/16952. But many developers use the wrong way to set position/rotation, so need to convert it to keep compatibility.

Continuous Integration

This pull request:

  • [x] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

minggo avatar Oct 21 '24 08:10 minggo

👍 Package size ⤵ -642 bytes, old: 5446634, new: 5445992

Interface Check Report

This pull request does not change any public interfaces !

github-actions[bot] avatar Oct 21 '24 08:10 github-actions[bot]

@minggo, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.5
  • Task Result: PASS
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/950aafd5-b333-4d06-9546-15be809abe2b/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/11437690462

Task Details

github-actions[bot] avatar Oct 21 '24 12:10 github-actions[bot]

@minggo, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.5
  • Task Result: PASS
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/514c81b8-5b87-4cbf-ae06-8ef034a1947c/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/11437690462

Task Details

github-actions[bot] avatar Oct 21 '24 12:10 github-actions[bot]