cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

[v3.8.5] cclegacy.xxx invocations should be converted to relevant type which will help refactoring and error reporting.

Open dumganhar opened this issue 1 year ago • 4 comments

Re: #

Changelog


Continuous Integration

This pull request:

  • [ ] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

dumganhar avatar Oct 21 '24 08:10 dumganhar

👍 Package size ⤵ -203 bytes, old: 5446634, new: 5446431

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -23776,9 +23776,9 @@
         csmLayers: __private._cocos_rendering_shadow_csm_layers__CSMLayers;
         octree: renderer.scene.Octree;
         skin: renderer.scene.Skin;
         postSettings: renderer.scene.PostSettings;
-        lightProbes: any;
+        lightProbes: LightProbes;
         /**
          * @en The list for valid punctual Lights, only available after the scene culling of the current frame.
          * @zh 场景中精确的有效光源,仅在当前帧的场景剔除完成后有效。
          */

github-actions[bot] avatar Oct 21 '24 08:10 github-actions[bot]

@cocos-robot run test cases

dumganhar avatar Oct 21 '24 09:10 dumganhar

@dumganhar, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.5
  • Task Result: PASS
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/f5897b48-8d6e-4eba-9d3b-5614d20f627f/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/11437097801

Task Details

github-actions[bot] avatar Oct 21 '24 11:10 github-actions[bot]

@dumganhar, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.5
  • Task Result: PASS
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/39ecd775-9a8b-4a60-b697-b9265e86285d/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/11437097801

Task Details

github-actions[bot] avatar Oct 21 '24 11:10 github-actions[bot]