cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

Fixing the SkeletonData export error.

Open bofeng-song opened this issue 6 months ago • 1 comments

Re: # https://github.com/cocos/cocos-engine-external/pull/457

Changelog


Continuous Integration

This pull request:

  • [ ] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

The pull request addresses the SkeletonData export error by modifying the build configuration and updating the Spine WASM bindings.

  • Build Configuration: Changed build type to 'MinSizeRel' in /native/cocos/editor-support/spine-wasm/CMakeLists.txt to reduce WebAssembly binary size.
  • New Vector Types: Added vector types for SlotData, TransformConstraintData, and PathConstraintData in /native/cocos/editor-support/spine-wasm/spine-type-export.cpp.
  • EMSCRIPTEN_BINDINGS Update: Updated EMSCRIPTEN_BINDINGS to include the new vector types in /native/cocos/editor-support/spine-wasm/spine-type-export.cpp.

Ensure all tests pass to verify the changes.

bofeng-song avatar Aug 09 '24 07:08 bofeng-song