cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

WeChat mini game platform remove splash-screen implementation

Open qiuguohua opened this issue 1 year ago • 10 comments

Re: #

Changelog


Continuous Integration

This pull request:

  • [x] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

The changes in cocos/game/splash-screen.ts add checks for the WECHAT constant to disable the splash screen for the WeChat mini game platform.

  • Added if (WECHAT) { return; } checks in init(), preInit(), initLayout(), initScale(), update(), initBG(), initLogo(), initWaterMark(), frame(), and destroy() methods.
  • Ensures splash screen is bypassed entirely on WeChat platform.
  • No impact on other platforms; functionality remains unchanged.
  • No security issues or logical errors detected.
  • Verify no dependencies on splash screen functionality elsewhere in the codebase.

qiuguohua avatar Aug 09 '24 02:08 qiuguohua

Interface Check Report

This pull request does not change any public interfaces !

github-actions[bot] avatar Aug 09 '24 03:08 github-actions[bot]

@cocos-robot run test cases

qiuguohua avatar Aug 09 '24 06:08 qiuguohua

@cocos-robot run test cases

qiuguohua avatar Aug 09 '24 06:08 qiuguohua

Please add some description in codes saying why do it like this.

minggo avatar Aug 09 '24 06:08 minggo

@qiuguohua, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.4
  • Task Result: PASS
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/11902eef-6fd3-4d0a-a11d-8f5eda0da544/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/10314501986

Task Details

github-actions[bot] avatar Aug 09 '24 07:08 github-actions[bot]

@qiuguohua, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.4
  • Task Result: PASS
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/2617c7e7-b57c-4f3c-956d-e5b07f442c58/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/10314501986

Task Details

github-actions[bot] avatar Aug 09 '24 07:08 github-actions[bot]

@qiuguohua, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.4
  • Task Result: PASS
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/159986a2-bc3b-4a26-8517-907ade428912/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/10315004373

Task Details

github-actions[bot] avatar Aug 09 '24 08:08 github-actions[bot]

@qiuguohua, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.4
  • Task Result: FAIL
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/741124ec-3c16-4f11-bc37-7a05c24fe843/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/10315004373

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS PASS
android PASS PASS FAIL LoadSpine
wechatgame PASS PASS PASS

github-actions[bot] avatar Aug 09 '24 08:08 github-actions[bot]

@qiuguohua, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.4
  • Task Result: PASS
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/7af185bc-483a-43b1-9b62-2fea6abbcca8/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/10316151037

Task Details

github-actions[bot] avatar Aug 09 '24 10:08 github-actions[bot]

@qiuguohua, Please check the result of run test cases:

  • Test Platform: PR-Test
  • Editor Version: v3.8.4
  • Task Result: PASS
  • Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/0a980d30-4fe8-43c3-96e3-6738e0c5dcd5/-1
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/10316151037

Task Details

github-actions[bot] avatar Aug 09 '24 10:08 github-actions[bot]