cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

update value as needed and reuse variables

Open minggo opened this issue 1 year ago • 3 comments

Re: https://github.com/cocos/cocos-engine/issues/16952

Changelog

  • reuse local variable
  • use static method of Vec3.set() and Quat.set() as they don't have to distinguish variable types, so they are more efficient
  • make Node.setWorldPosition(), Node.setWorldRotation(), Node.setWorldRotationFromEuler(), Node.setWorldScale() update values add needed

Continuous Integration

This pull request:

  • [ ] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

minggo avatar May 13 '24 08:05 minggo

Interface Check Report

This pull request does not change any public interfaces !

github-actions[bot] avatar May 13 '24 08:05 github-actions[bot]

@cocos-robot run test cases

minggo avatar May 21 '24 05:05 minggo

@cocos-robot run test cases

minggo avatar May 23 '24 07:05 minggo

@minggo :exclamation: There was an error during the execution of the tasks. Please check the logs for more details.

github-actions[bot] avatar May 24 '24 01:05 github-actions[bot]