cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

Published 20 hours ago • verified publisher icon cocos

fix-bug:nodepool.get

Open ljk123 opened this issue 3 months ago • 3 comments

Re: #

Changelog

Continuous Integration

This pull request:

  • [ ] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

ljk123 avatar Mar 20 '24 08:03 ljk123

Interface Check Report

This pull request does not change any public interfaces !

github-actions[bot] avatar Mar 20 '24 08:03 github-actions[bot]

What's the bug?

minggo avatar Apr 17 '24 03:04 minggo 

interface IPoolHandlerComponent extends Component {
    unuse (): void;
    reuse (args: any): void;
}

The reuse function definition was changed in this PR: https://github.com/cocos/cocos-engine/pull/7101/files#diff-e7e7f9bb9a7fcedd94a2573a867502af9c4c48cd0a57a0a15c1569fd1111b5fe which changed the reuse argument behavior.

The original reuse accessed spread arguments but now it's just one args with any type. I think it was a mistake which modify reuse function syntax.

dumganhar avatar Apr 17 '24 03:04 dumganhar