cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

support char mode emoji and multibyte emoji like ๐Ÿ‘จโ€๐Ÿ‘ฉโ€๐Ÿ‘งโ€๐Ÿ‘ฆ

Open qiuguohua opened this issue 2 years ago โ€ข 2 comments

https://github.com/cocos/cocos-engine/issues/15192 https://github.com/cocos/cocos-engine/pull/16687#pullrequestreview-1887694982

Re: #

Changelog

  1. Optimize character expression processing
  2. Add unit test

Continuous Integration

This pull request:

  • [x] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

qiuguohua avatar Feb 20 '24 02:02 qiuguohua

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -3823,8 +3823,11 @@
     /**
      * @deprecated since v3.7.2, this is an engine private interface that will be removed in the future.
      */
     export function safeMeasureText(ctx: CanvasRenderingContext2D, string: string, desc?: string): number;
+    export function getSymbolLength(str: string): number;
+    export function getSymbolAt(str: string, index: number): string;
+    export function getSymbolCodeAt(str: string, index: number): string;
     /**
      * @deprecated since v3.7.2, this is an engine private interface that will be removed in the future.
      */
     export function fragmentText(stringToken: string, allWidth: number, maxWidth: number, measureText: (string: string) => number): string[];

github-actions[bot] avatar Feb 20 '24 02:02 github-actions[bot]

Please fix eslint error as possible.

minggo avatar Feb 20 '24 03:02 minggo

@cocos-robot run test cases

sushanhong avatar Mar 04 '24 01:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 04 '24 07:03 sushanhong

https://github.com/cocos/cocos-engine/issues/16710

qiuguohua avatar Mar 04 '24 08:03 qiuguohua

@cocos-robot run test cases

sushanhong avatar Mar 05 '24 07:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 22 '24 03:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 22 '24 03:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 22 '24 06:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 03:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 06:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 06:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 06:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 07:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 08:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 08:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 08:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 08:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 08:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 08:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 08:03 sushanhong

@cocos-robot run test cases

sushanhong avatar Mar 25 '24 08:03 sushanhong