cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

Published 20 hours ago • verified publisher icon cocos

gpu objects use smart pointer

Open bluesky013 opened this issue 3 years ago • 17 comments

Re: #

Changelog

  • gpu objects use smart pointer
  • update bufferView binding in descriptor set after buffer resize

Continuous Integration

This pull request:

  • [x] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

bluesky013 avatar Sep 09 '22 07:09 bluesky013

@cocos-robot run test cases

bluesky013 avatar Sep 09 '22 07:09 bluesky013

Interface Check Report

This pull request does not change any public interfaces !

github-actions[bot] avatar Sep 09 '22 07:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/833/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3020757096

Task Details

No task results found.

github-actions[bot] avatar Sep 09 '22 08:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/919/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3020757096

Task Details

No task results found.

github-actions[bot] avatar Sep 09 '22 08:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/834/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3020769507

Task Details

No task results found.

github-actions[bot] avatar Sep 09 '22 09:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/920/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3020769507

Task Details

No task results found.

github-actions[bot] avatar Sep 09 '22 09:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/946/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3058603171

Task Details

No task results found.

github-actions[bot] avatar Sep 15 '22 07:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version: V3.6.1-20220914-64fca37
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/947/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3058631657

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release FAIL NA NA NA
Android_debug FAIL NA NA NA

github-actions[bot] avatar Sep 15 '22 07:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version: V3.6.1-20220914-64fca37
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/948/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3058891617

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release FAIL NA NA NA
Android_debug FAIL NA NA NA

github-actions[bot] avatar Sep 15 '22 08:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version: V3.6.1-20220914-64fca37
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/860/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3058999821

Task Details

Platform build runned result crashScene FailScene
ios_release FAIL NA NA NA
Mac_debug FAIL NA NA NA
WebMobile_debug PASS PASS PASS NA

github-actions[bot] avatar Sep 15 '22 09:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version: V3.6.1-20220914-64fca37
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/949/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3058999821

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release FAIL NA NA NA
Android_debug FAIL NA NA NA

github-actions[bot] avatar Sep 15 '22 09:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version: V3.6.1-20220914-64fca37
  • Task Result: PASS
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/863/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3065275867

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS PASS NA
Mac_debug PASS PASS PASS NA
WebMobile_debug PASS PASS PASS NA

github-actions[bot] avatar Sep 16 '22 04:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version: V3.6.1-20220914-64fca37
  • Task Result: PASS
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/952/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3065275867

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release PASS PASS PASS NA
Android_debug PASS PASS PASS NA

github-actions[bot] avatar Sep 16 '22 04:09 github-actions[bot]

How to make sure getObjectID(Agent<GFXBuffer>* buffer) and getObjectID(GFXBuffer*) keep consistent? Or is there any mechanism makes it doesn't matter even thery are different?

hana-alice avatar Sep 16 '22 07:09 hana-alice

How to make sure getObjectID(Agent<GFXBuffer>* buffer) and getObjectID(GFXBuffer*) keep consistent? Or is there any mechanism makes it doesn't matter even thery are different?

There are two gfx::Buffer instance in Agent<gfx::Buffer>

gfx::Agent<gfx::Buffer> *bufferAgent = deviceAgent.createBuffer();
gfx::Buffer* buffer = static_cast<gfx::Buffer*>(bufferAgent);
gfx::Buffer* bufferActor = bufferAgent->actor;

// 1. first instance
getObjectID(bufferAgent) == getObjectID(buffer); // objectID1

// 2. second instance
getObjectID(bufferActor); // objectID2

Agent shoud care which one to use.

bluesky013 avatar Sep 16 '22 08:09 bluesky013

@bluesky013, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version: V3.6.1-20220914-64fca37
  • Task Result: PASS
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/871/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3066646561

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS PASS NA
Mac_debug PASS PASS PASS NA
WebMobile_debug PASS PASS PASS NA

github-actions[bot] avatar Sep 16 '22 10:09 github-actions[bot]

@bluesky013, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version: V3.6.1-20220914-64fca37
  • Task Result: PASS
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/960/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/3066646561

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release PASS PASS PASS NA
Android_debug PASS PASS PASS NA

github-actions[bot] avatar Sep 16 '22 10:09 github-actions[bot]