cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

[optimization] Use define to replace uniform

Open troublemaker52025 opened this issue 3 years ago • 7 comments
trafficstars

Re: #

Changelog


Continuous Integration

This pull request:

  • [x] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

troublemaker52025 avatar Aug 09 '22 03:08 troublemaker52025

@cocos-robot run test cases

troublemaker52025 avatar Aug 09 '22 03:08 troublemaker52025

@troublemaker52025, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version:
  • Task Result:
  • Task URL:
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2822442149

Task Details

github-actions[bot] avatar Aug 09 '22 03:08 github-actions[bot]

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -7446,8 +7446,14 @@
                  * @en x9 times
                  * @readonly
                  */
                 SOFT_2X: number;
+                /**
+                 * @zh x16 次采样
+                 * @en x16 times
+                 * @readonly
+                 */
+                SOFT_4X: number;
             };
             /**
              * @zh 级联阴影贴图层级。
              * @en The CSM shadow level

github-actions[bot] avatar Aug 09 '22 03:08 github-actions[bot]

@troublemaker52025, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version:
  • Task Result:
  • Task URL:
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2822442149

Task Details

github-actions[bot] avatar Aug 09 '22 03:08 github-actions[bot]

@troublemaker52025, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/666/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823822782

Task Details

No task results found.

github-actions[bot] avatar Aug 09 '22 08:08 github-actions[bot]

@troublemaker52025, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/747/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823822782

Task Details

No task results found.

github-actions[bot] avatar Aug 09 '22 08:08 github-actions[bot]

需要同步到原生

troublemaker52025 avatar Aug 11 '22 09:08 troublemaker52025

@troublemaker52025, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version: V3.6.1-20220815-0ded93c
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/691/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2858063340

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS FAIL NA BuildTimeConstantsTest,shadowCulling
Mac_debug PASS PASS FAIL NA BuildTimeConstantsTest,shadowCulling
WebMobile_debug PASS PASS FAIL NA BuildTimeConstantsTest

github-actions[bot] avatar Aug 15 '22 02:08 github-actions[bot]

@troublemaker52025, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version: V3.6.1-20220815-0ded93c
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/764/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2858063340

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release FAIL NA NA NA

github-actions[bot] avatar Aug 15 '22 03:08 github-actions[bot]

@troublemaker52025, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version: V3.6.1-20220815-0ded93c
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/695/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2859853585

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS FAIL NA BuildTimeConstantsTest,align-mode,deprecated,layout-basic-grid,layout-basic-horizontal,layout-basic-verticle,layout-change-sibling,layout-scrollview,opacity,rich-text-align,rich-text,system-font
Mac_debug PASS PASS FAIL NA BuildTimeConstantsTest,rich-text
WebMobile_debug PASS PASS FAIL NA BuildTimeConstantsTest

github-actions[bot] avatar Aug 15 '22 10:08 github-actions[bot]

@troublemaker52025, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version: V3.6.1-20220815-0ded93c
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/768/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2859853585

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release FAIL NA NA NA

github-actions[bot] avatar Aug 15 '22 11:08 github-actions[bot]