cocos-engine
cocos-engine copied to clipboard
fix wrong transfrom calc when scale value is negative
Re: #https://github.com/cocos/3d-tasks/issues/12675
Changelog
Continuous Integration
This pull request:
- [x] needs automatic test cases check.
Manual trigger with
@cocos-robot run test casesafterward. - [ ] does not change any runtime related code or build configuration
If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.
Compatibility Check
This pull request:
- [ ] changes public API, and have ensured backward compatibility with deprecated features.
- [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
- [ ] affects file structure of the build package or build configuration which requires user project upgrade.
- [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.
Interface Check Report
This pull request does not change any public interfaces !
Please rebase your changes.
@mmyduckx, Please check the result of run test cases:
- Test Platform: macOS
- Task Result: FAIL,Job: CocosGitHub/PR_Action/mac FAILURE, Please confirm task details: http://lan-jenkins.cocos.org:8080/job/CocosGitHub/job/PR_Action/job/mac/588/
- Task URL: http://lan-jenkins.cocos.org:8080/job/CocosGitHub/job/PR_Action/job/mac/588/
- GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2730513961
Task Details
Congratulations on your complete success!
@mmyduckx, Please check the result of run test cases:
- Test Platform: Windows
- Task Result: FAIL,Job: CocosGitHub/PR_Action/windows FAILURE, Please confirm task details: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/667/
- Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/667/
- GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2730513961
Task Details
None
@mmyduckx, Please check the result of run test cases:
- Test Platform: macOS
- Editor Version:
- Task Result: FAIL
- Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/664/
- GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823447505
Task Details
Please confirm the CocosCreator version(develop)
@mmyduckx, Please check the result of run test cases:
- Test Platform: Windows
- Editor Version:
- Task Result: FAIL
- Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/746/
- GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823447505
Task Details
Please confirm the CocosCreator version(develop)
@mmyduckx, Please check the result of run test cases:
- Test Platform: macOS
- Editor Version:
- Task Result: FAIL
- Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/665/
- GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823728944
Task Details
No task results found.
@mmyduckx, Please check the result of run test cases:
- Test Platform: Windows
- Editor Version:
- Task Result: FAIL
- Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/762/
- GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823728944
Task Details
Please confirm the CocosCreator version(develop)
This change will cause the problem that when setting Position & eulerAngles or Position & Scale run well, but when setting eulerAngles and Scale at one time will calculate wrong transform data.
The reason maybe we cannot calculate rotation and scale separately from matrix transform.
Still need to figure out the right way to calculate.