cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

fix wrong transfrom calc when scale value is negative

Open mmyduckx opened this issue 3 years ago • 7 comments

Re: #https://github.com/cocos/3d-tasks/issues/12675

Changelog


Continuous Integration

This pull request:

  • [x] needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • [ ] does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • [ ] changes public API, and have ensured backward compatibility with deprecated features.
  • [ ] affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • [ ] affects file structure of the build package or build configuration which requires user project upgrade.
  • [ ] introduces breaking changes, please list all changes, affected features and the scope of violation.

mmyduckx avatar Jul 23 '22 10:07 mmyduckx

Interface Check Report

This pull request does not change any public interfaces !

github-actions[bot] avatar Jul 23 '22 10:07 github-actions[bot]

Please rebase your changes.

dumganhar avatar Jul 25 '22 04:07 dumganhar

@mmyduckx, Please check the result of run test cases:

  • Test Platform: macOS
  • Task Result: FAIL,Job: CocosGitHub/PR_Action/mac FAILURE, Please confirm task details: http://lan-jenkins.cocos.org:8080/job/CocosGitHub/job/PR_Action/job/mac/588/
  • Task URL: http://lan-jenkins.cocos.org:8080/job/CocosGitHub/job/PR_Action/job/mac/588/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2730513961

Task Details

Congratulations on your complete success!

github-actions[bot] avatar Jul 25 '22 07:07 github-actions[bot]

@mmyduckx, Please check the result of run test cases:

  • Test Platform: Windows
  • Task Result: FAIL,Job: CocosGitHub/PR_Action/windows FAILURE, Please confirm task details: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/667/
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/667/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2730513961

Task Details

None

github-actions[bot] avatar Jul 25 '22 07:07 github-actions[bot]

@mmyduckx, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/664/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823447505

Task Details

Please confirm the CocosCreator version(develop)

github-actions[bot] avatar Aug 09 '22 07:08 github-actions[bot]

@mmyduckx, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/746/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823447505

Task Details

Please confirm the CocosCreator version(develop)

github-actions[bot] avatar Aug 09 '22 07:08 github-actions[bot]

@mmyduckx, Please check the result of run test cases:

  • Test Platform: macOS
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/mac/665/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823728944

Task Details

No task results found.

github-actions[bot] avatar Aug 09 '22 08:08 github-actions[bot]

@mmyduckx, Please check the result of run test cases:

  • Test Platform: Windows
  • Editor Version:
  • Task Result: FAIL
  • Task URL: http://lan-jenkins.cocos.org/job/CocosGitHub/job/PR_Action/job/windows/762/
  • GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/2823728944

Task Details

Please confirm the CocosCreator version(develop)

github-actions[bot] avatar Aug 12 '22 10:08 github-actions[bot]

wecom-temp-d4eeb806d57b805ba9138155aedd2598 This change will cause the problem that when setting Position & eulerAngles or Position & Scale run well, but when setting eulerAngles and Scale at one time will calculate wrong transform data. The reason maybe we cannot calculate rotation and scale separately from matrix transform.

Still need to figure out the right way to calculate.

mmyduckx avatar Aug 15 '22 02:08 mmyduckx