cocos-engine icon indicating copy to clipboard operation
cocos-engine copied to clipboard

Native Glslang upgrade

Open yiwenxue opened this issue 3 years ago • 5 comments

Our Glslang library is out of date, and doesn't support Vulkan 1.3, so cocos game will crash when running with Vulkan 1.3.

The solution contains two parts:

  • [x] Add new VK flags to cocos-engine.
  • [ ] upgrade the Glslang libraries in cocos-external-project to 11.10.0.

yiwenxue avatar Jun 21 '22 07:06 yiwenxue

The first part https://github.com/cocos/cocos-engine/pull/11445#issue-1265966110

yiwenxue avatar Jun 21 '22 07:06 yiwenxue

https://github.com/cocos/cocos-engine/issues/11849

star-e avatar Jul 05 '22 06:07 star-e

Update glslang will cause crash on some Android devices. @star-e i suggest to move this issue to other milestone, treat it as a known issue.

minggo avatar Jul 09 '22 03:07 minggo

i suggest to move this issue to other milestone, treat it as a known issue.

I agree. It is too risky to upgrade in v3.6. @minggo

star-e avatar Jul 09 '22 05:07 star-e

目前有两个可用的解决方案:

  1. 降级 vulkan SDK 和 gpu driver。
  2. 下载较新的 spirv 库,可以用这个解压替换 engine/native/external/sources/glslang 目录,可以暂时正常使用。 glslang.zip

yiwenxue avatar Jul 28 '22 03:07 yiwenxue

glslang 有对旧版本的兼容,新的 vulkan sdk 已经 fallback 到了旧版本上面之后 3.6 都没有遇到问题。

yiwenxue avatar Dec 02 '22 07:12 yiwenxue

@yiwenxue please use english in future. If so, can close this issue?

minggo avatar Feb 16 '23 08:02 minggo

@yiwenxue please use english in future. If so, can close this issue?

Ok, I will.

No need to upgrade glslang since the fallback works fine, problem solved let's close it.

yiwenxue avatar Feb 16 '23 08:02 yiwenxue