Add link to iterm theme port

[epszaw]

[gkeep]

Looks good!

Could you also add the dark theme to your repository, too? I know terminal.sexy provides it via .xresources, but it would be nice to have it in a dedicated repository, too.

[epszaw]

I think yes. Will made port today 👍

[epszaw]

@gkeep done

[epszaw]

@cocopon what do you think about the merge? 🙂

[cocopon]

Thank you for your contribution, and sorry for my late reply...

• Could you fix the app name in readme from iterm2 to iTerm2?
• I prefer that the cursor color is same as its foreground color. What do you think?
• Could you re-check a color for Links and Cursor of the light theme? It is not a color in the palette.

[epszaw]

Yes, I will check it on this week.

[epszaw]

@cocopon it's done for cursor color in the light theme and readme fix is also pushed. But I not fully understood you about links colors. I checked blue and magenta colors (commonly links are highlighted with these colors) and they're right. Can you explain?

[cocopon]

it's done for cursor color in the light theme and readme fix is also pushed.

Thank you!

Here is a screenshot of Links: (005bbb is not a part of Iceberg palette)

and it will be applied to URL-like text when command key is pressed:

[epszaw]

Finally, I got it! Done, @cocopon !

[cocopon]

Thank you! Could you re-check a color for Curosor? It seems to be back to the previous value.

[epszaw]

@cocopon done. Again :)

[cocopon]

Links seems to be back to the previous value again... https://github.com/lamartire/iceberg-iterm/commit/bc40281501f90cecafb079e37396d51d7ae9a20d#diff-a35d9d7d08ac24d890c8b56d8b3e815ceb9c00c940edd384d435a23e732fb143R308-R315

[epszaw]

@cocopon again :D

[epszaw]

@cocopon any new here?

[cocopon]

It seems to be fixed.

BTW, what is Bold? I noticed that this is also not a color of the palette.

[epszaw]

It seems to be fixed.

BTW, what is Bold? I noticed that this is also not a color of the palette.

Which color will fit better here? What do you think? I propose to use #33374c (foreground) or #8389a3 (white bright).

[cocopon]

Do you know how to check a bold text? I'd like to check it on the actual terminal but haven't found a way to print it yet.

[epszaw]

That it.

Source code here (you need to install chalk):

const chalk = require('chalk')

console.log(chalk.bold('Bold text here!'))

[cocopon]

Thank you for sharing the code! I understand. white bright seems better for this case.

[epszaw]

@cocopon done for the both themes! ❤️

[cocopon]

• Dark Foreground should be #c6c8d1
• Light Bold should be #262a3f
• Light Links seems to be back to the previous value again...

[epszaw]

I'm sorry, but iterm2 has some problems with themes exporting. Check it please again.

[cocopon]

Found additional issues:

• Dark Cursor should be same as Foreground (#c6c8d1)
• Dark Cursor text should be same as Background (#161821)
• Dark Selected text should be same as Foreground (#c6c8d1)
• Light Cursor text should be same as Background (#e8e9ec)
• Light Selection should be same as Visual of Vim (#c9cdd7)
• Cursor guide should be same as Cursorline of Vim
  • Dark: #1e2132
  • Light: #dcdfe7

[epszaw]

@cocopon done here

[cocopon]

• These values are rolled back... Please, please re-check ALL colors before/after commit:
  • Dark Foreground
  • Dark Bold
  • Light Bold
  • Light Links
• Should Cursor guide have alpha? I think opaque color is better

[cocopon]

Feel free to reopen the issue if you have any updates.

[epszaw]

@cocopon yeah, when I'll done it – I write you and reopen the issue

[epszaw]

@cocopon seems like I fix here everything. I hope, that's really everything now.

[epszaw]

So, I can't reopen this PR. Should I create new one?

[epszaw]

@cocopon can you review the last changes?