iceberg.vim icon indicating copy to clipboard operation
iceberg.vim copied to clipboard

Add support for iTerm2

Open YusukeSano opened this issue 3 years ago • 3 comments

The terminal.sexy provides iTerm2 color schemes via .Xresources, but some settings, such as Selection and Link, are not supported.

So I created a complete Icebreg for iTerm2 and added port links.

Before After

This also supports separate color settings for light & dark modes, which will be added in the latest beta (3.5) of iTerm2.

Light Dark

YusukeSano avatar Aug 20 '22 01:08 YusukeSano

hi, just a fan of iceberg here, looking to use it for iTerm2 too. Do you think you could give a brief summary of how your version compares versus https://github.com/epszaw/iceberg-iterm (from https://github.com/cocopon/iceberg.vim/pull/80) ? Thank you!

jf avatar May 21 '23 13:05 jf

hi, just a fan of iceberg here, looking to use it for iTerm2 too. Do you think you could give a brief summary of how your version compares versus https://github.com/epszaw/iceberg-iterm (from #80) ? Thank you!

Sure! Here's a summary of my color theme file compared to the #80 version of the theme:

  • Compatibility: My theme files are designed to support light & dark mode since version 3.5.
  • Consistency: It aligns with the original .Xresources file for a consistent color experience.
  • Enhanced Colors: I have referenced the VSCode theme file to enrich the color palette.
  • Accurate Representation: The theme file was created using the precise sRGB color values from the iTerm2 Theme Generator.

In summary, my version provides improved compatibility, consistent colors, enhanced palette, and accurate representation.

YusukeSano avatar May 29 '23 16:05 YusukeSano

thank you @YusukeSano ! @cocopon , do you think you could take a look and see if you're ok with this PR? Thank you!

jf avatar May 31 '23 13:05 jf

iTerm2 version 3.5 has been released! (https://iterm2.com/downloads.html)

Version 3.5 supports color profiles for both light and dark modes. Additionally, a new find match background color has been added.

Unfortunately, terminal.sexy and #80 do not support the correct terminal colors. However, Icebreg for iTerm2 fully supports all these updates.

light dark
light dark

Would you kindly review this pull request, @cocopon?

YusukeSano avatar May 25 '24 17:05 YusukeSano

Can confirm, looks and works great. Thanks, @YusukeSano!

gkeep avatar May 25 '24 19:05 gkeep

Thank you for your contribution! (also thanks to @gkeep for reviewing it!)

cocopon avatar Jun 17 '24 14:06 cocopon

thank you everybody! @cocopon I previously (see https://github.com/cocopon/iceberg.vim/pull/105#issuecomment-1556186937) asked @YusukeSano to compare his work vs #80, and he has kindly done so. If you've accepted this PR, would you also reject #80?

jf avatar Jun 17 '24 23:06 jf