adb_client icon indicating copy to clipboard operation
adb_client copied to clipboard

feat: adb list

Open J05HM0N5TER opened this issue 8 months ago • 8 comments

ADB List (ls) for both direct device communication and for communication though the ADB server.

J05HM0N5TER avatar Apr 05 '25 06:04 J05HM0N5TER

I have tested this with both ADB server USB and direct USB communication. I have not tested it through TCP connection.

J05HM0N5TER avatar Apr 05 '25 06:04 J05HM0N5TER

Hi @J05HM0N5TER , thanks for the PR ! Will have a look at it this week :)

cocool97 avatar Apr 06 '25 17:04 cocool97

I rebased latest main changes on your branch

cocool97 avatar Apr 13 '25 15:04 cocool97

Also removed duplicate list command that was causing cargo run --bin adb_cli -- local --help to fail

cocool97 avatar Apr 13 '25 15:04 cocool97

@cocool97 I think I might have messed up your rebase. I happened to be working on it as you did your stuff and I thought I messed up my branch though some local moving of get repos, and did a git push --force-with-lease.

Can you please re-push your local version to undo my undo of the rebase you did? I have the fixes for some of your comments locally, but I'll just stash them for now to not make the git history more complicated.

If it is too much of a mess, we can just squash merge this at the end and remove all the extra stuff.

J05HM0N5TER avatar Apr 13 '25 15:04 J05HM0N5TER

Also removed duplicate list command that was causing cargo run --bin adb_cli -- local --help to fail

Thanks for that. I was a bit confused on how there seemed to be two different places that the commands a defined in. I thought that the definitions of the commands that were against the ADB server were completely disconnected from the ones that interacted directly with the device.

J05HM0N5TER avatar Apr 13 '25 15:04 J05HM0N5TER

Thanks for you recent changes, I'll review it asap :)

Can you fix the failing fmt job ?

cocool97 avatar May 04 '25 15:05 cocool97

Thanks for you recent changes, I'll review it asap :)

Can you fix the failing fmt job ?

I just pushed the changes to fix the fmt, could you please rerun the workflow?

J05HM0N5TER avatar May 05 '25 09:05 J05HM0N5TER