cocoindex icon indicating copy to clipboard operation
cocoindex copied to clipboard

[BUG] Gracefully handle SIGINT and propagate from Rust to Python

Open georgeh0 opened this issue 3 months ago • 6 comments

From users:

Calls to flow.Flow.update() and flow.Flow.setup() don't seem to handle SIGINT. So, could not gracefully terminate if any errors during long indexing runs. Perhaps it should return cancellation handle to the caller for signaling stop. TY!

When running Rust code with GIL held, if there's SIGINT, it's not propagated to Python properly.

georgeh0 avatar Sep 17 '25 01:09 georgeh0

the python execution wrapper is actually hiding the SIGINT flow.update() doesnt even use an early cancel path once started and only aborts in exir and not on SIGINT

I'm working on this issue, please assign it to me

Duckaet avatar Oct 01 '25 12:10 Duckaet

@Duckaet welcome to contribute!

georgeh0 avatar Oct 01 '25 15:10 georgeh0

@Duckaet are you still active on this?

badmonster0 avatar Oct 12 '25 19:10 badmonster0

Sorry for being inactive @badmonster0 , i have almost implemented sigint succesfully with 3 of my tests failing will fix em, and will raise a pr tomorrow

Duckaet avatar Oct 12 '25 23:10 Duckaet

Got it @Duckaet , thanks a lot for getting back to us!

badmonster0 avatar Oct 14 '25 03:10 badmonster0

@badmonster0 @georgeh0

I wasn't able to handle the issue correctly, can you assign this issue to someone else

Duckaet avatar Oct 17 '25 14:10 Duckaet