helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

grpc internal port should be configured from one place only

Open prafull01 opened this issue 1 year ago • 0 comments

We recommend separating internal grpc port from sql port for large scale clusters.

In Helm chart in order to change internal grpc port we need to configure it at two places:

service:
  ports:
    # You can set a different external and internal gRPC ports and their name.
    grpc:
      external:
        port: 26257
        name: grpc
      # If the port number is different than `external.port`, then it will be
      # named as `internal.name` in Service.
      internal:
        port: 26257
        # If using Istio set it to `cockroach`.
        name: grpc-internal
    http:
      port: 8080 
      name: http

Also the same port is defined:

conf:
  port: 26257
  http-port: 8080

Ideally this configuration at one place so that user doesn't have to change at two place.

--port & --http-port has been depreciated, but they’re still used in Helm chart, we should deprecate those port in helm chart.

prafull01 avatar Sep 19 '24 09:09 prafull01