helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon cockroachdb

Add custom fields to self signer jobs

Open 81887821 opened this issue 1 year ago • 2 comments

Currently annotations, affinity, node selector and tolerations are only applied to self signer init job. It would be better if those are also applied to rotate cronjobs and clean-up job. My use case is to disable Istio sidecar injection to the clean-up job.

81887821 avatar Jan 26 '24 08:01 81887821

It will be great supporting both additional labels and annotations. For your reference, the current related code is here: https://github.com/cockroachdb/helm-charts/blob/0cba0b68def62547888f52d6183a736af4c06292/cockroachdb/templates/job-cleaner.yaml#L20-L26

umi0410 avatar Jan 31 '24 02:01 umi0410

Added support for labels

81887821 avatar Feb 01 '24 07:02 81887821

@prafull01 can you take a look at this please?

@81887821 can you please rebase with master?

udnay avatar Sep 06 '24 12:09 udnay

@udnay done

81887821 avatar Sep 11 '24 08:09 81887821

LGTM, Approved. @81887821 Please rebase again, so that I can merge this change.

prafull01 avatar Sep 18 '24 07:09 prafull01