helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon cockroachdb

Add option to set the ingress class name

Open mtneug opened this issue 3 years ago • 2 comments

The ingressClassName configuration option should be used instead of custom ingress dependent annotations. This adds a new value to the ingress configuration to set this option.

mtneug avatar Sep 26 '22 13:09 mtneug

It would make sense to also check beforehand if the ingress resource can handle ingressClassName like well known other helm repos do (e.g. Grafanalabs: https://github.com/grafana/helm-charts/blob/316f4a28aed5aa35819fbc11673ab76e1a95cede/charts/tempo/templates/_helpers.tpl#L93-L105)

zadjadr avatar Jan 19 '24 13:01 zadjadr

IMO at this point I would move on to only support networking.k8s.io/v1. This version was GA in Kubernetes 1.19 (released mid 2020).

mtneug avatar Jan 19 '24 14:01 mtneug