helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Use `tls.enabled` to conditionally render the client rotation cronjob

Open ckoehn opened this issue 3 years ago • 0 comments

Currently the certificate rotation cronjob for the clients and nodes is rendered even if tls.enabled is disabled. https://github.com/cockroachdb/helm-charts/blob/da0ac4372c7b34144a904c4999fbc1fb17676895/cockroachdb/templates/cronjob-client-node-certSelfSigner.yaml#L1

The check should be similar to https://github.com/cockroachdb/helm-charts/blob/da0ac4372c7b34144a904c4999fbc1fb17676895/cockroachdb/templates/cronjob-ca-certSelfSigner.yaml#L1

ckoehn avatar Nov 15 '21 14:11 ckoehn