docs icon indicating copy to clipboard operation
docs copied to clipboard

Update COMMENT ON docs for types

Open rmloveland opened this issue 1 year ago • 4 comments

Fixes DOC-10455

rmloveland avatar Jul 24 '24 19:07 rmloveland

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
Latest commit ecfa32a149e0ce6982b0bdf371ba216748485710
Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66b50d80a11b1000081dd6ac

netlify[bot] avatar Jul 24 '24 19:07 netlify[bot]

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
Latest commit ecfa32a149e0ce6982b0bdf371ba216748485710
Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66b50d80692d4d000842a719

netlify[bot] avatar Jul 24 '24 19:07 netlify[bot]

Netlify Preview

Name Link
Latest commit ecfa32a149e0ce6982b0bdf371ba216748485710
Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66b50d8067623f000840ce57
Deploy Preview https://deploy-preview-18761--cockroachdb-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 24 '24 19:07 netlify[bot]

this lgtm!

Thanks for the review!

i have a supernit so feel free to disregard, but what do you think about separating out the Add or remove a comment to or from a type into Add a comment to a type and Remove a comment from a type

fixed, not a nit! thanks

so it aligns more with how we do database comment adding/removal? With Remove a comment from a type being below Remove a comment from a database so that the ordering matches

should be fixed now

thanks again for taking this review!

rmloveland avatar Aug 08 '24 15:08 rmloveland