docs icon indicating copy to clipboard operation
docs copied to clipboard

[DO NOT MERGE] Test support warning (re. assistance-only support and EOL) future states

Open mikeCRL opened this issue 1 year ago • 7 comments

A test, following on https://github.com/cockroachdb/docs/pull/18611

mikeCRL avatar Jun 03 '24 17:06 mikeCRL

Files changed:

  • src/current/_includes/sidebar-data-v23.1.json
  • src/current/_includes/unsupported-version.md
  • src/current/_includes/v23.1/sidebar-data/latest-releases.json
  • src/current/_layouts/page.html

github-actions[bot] avatar Jun 03 '24 17:06 github-actions[bot]

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
Latest commit ea7205a5df4156ed1a2d9f7e2e39ca58dea4ab0c
Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66677ba8d51d1b0008c0da06

netlify[bot] avatar Jun 03 '24 17:06 netlify[bot]

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
Latest commit ea7205a5df4156ed1a2d9f7e2e39ca58dea4ab0c
Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66677ba8b2db0500094420c8

netlify[bot] avatar Jun 03 '24 17:06 netlify[bot]

Netlify Preview

Name Link
Latest commit ea7205a5df4156ed1a2d9f7e2e39ca58dea4ab0c
Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66677ba863a7490008b1adf2
Deploy Preview https://deploy-preview-18615--cockroachdb-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 03 '24 17:06 netlify[bot]

@mdlinville When I manually set today to 2025-11-14, the warnings on these pages look good:

  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/releases/v23.1
  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/releases/v23.2
  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/releases/v24.1

But shouldn't a warning also appear at the top of every doc page in 23.1 and 23.2? Nothing's showing up here:

  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/v23.1/authentication
  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/v23.2/authentication

Am I missing something, or is there a bug?

Note: The reason I continued to set a variable actual_today was to troubleshoot an earlier issue with my code; the idea was to add something like

Actually today: {{ actual_today }}
Future: {{ today }}

to validate the assignment of each. But I didn't need to do that, because the latest today code here seems to be working now.

mikeCRL avatar Jun 04 '24 17:06 mikeCRL

@mdlinville When I manually set today to 2025-11-14, the warnings on these pages look good:

  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/releases/v23.1
  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/releases/v23.2
  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/releases/v24.1

But shouldn't a warning also appear at the top of every doc page in 23.1 and 23.2? Nothing's showing up here:

  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/v23.1/authentication
  • https://deploy-preview-18615--cockroachdb-docs.netlify.app/docs/v23.2/authentication

Am I missing something, or is there a bug?

Note: The reason I continued to set a variable actual_today was to troubleshoot an earlier issue with my code; the idea was to add something like

Actually today: {{ actual_today }}
Future: {{ today }}

to validate the assignment of each. But I didn't need to do that, because the latest today code here seems to be working now.

Can you rerun the test and instead of changing today, change the dates in versions.csv such that a given version looks to be EOL, or LTS maintenance, or whatever?

mdlinville avatar Jun 04 '24 19:06 mdlinville

I think this is ready to test again. When we are satisfied, we should decouple the logic changes and put them in another PR.

mdlinville avatar Jun 10 '24 22:06 mdlinville