v24.1 release notes should mention expected increase in memory usage

[nvanbenschoten]

Nathan VanBenschoten (nvanbenschoten) commented:

In v24.1, we made the following change: https://github.com/cockroachdb/cockroach/pull/119605. This PR sets a default value for the GOGC of 300, which will allow the Go memory to quadruple before each garbage collection. The old default was to GC each time the memory doubled.

This will look like an increase in "Memory usage" in the Hardware dashboard and an increase in "Go total memory usage" in the Runtime dashboard. This should not cause OOMs, as the Go memory limit (controlled by --max-go-memory flag) will still prevent Go memory from growing too large. Still, it may be concerning to users who are not expecting it (like it was in this thread), so we should call it out in the release notes.

Jira Issue: DOC-10266

[michae2]

Related to this: --go-gc-percent is documented in release notes but not in the list of command-line options for cockroach start. It would be nice to have it documented in both places.

[rmloveland]

Totes agreed, I will handle this via the following issue

https://cockroachlabs.atlassian.net/browse/DOC-9879

right now I'm working on v24.2.0 release stuff but if this doesn't get done this summer please come yell at me over there

Michael Erickson @.***> writes:

Related to this: --go-gc-percent is documented in release notes but not in the list of command-line options for cockroach start. It would be nice to have it documented in both places.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.