datadriven icon indicating copy to clipboard operation
datadriven copied to clipboard

subtests interact badly with -rewrite

Open RaduBerinde opened this issue 4 years ago • 0 comments

If you try to run a subtest and pass -rewrite, the outcome is bad (all tests that did not run disappear).

We should either make it work (by not modifying the tests that did not run) or detect when a test filter is in place and disallow -rewrite. One way to detect would be to count how many of our .Run() calls actually run, and bail at the end if we didn't run anything.

We should make a similar change to the logictests.

RaduBerinde avatar Apr 28 '20 12:04 RaduBerinde