cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

kvserver: add storage time-series metrics for level size and score

Open nicktrav opened this issue 3 years ago • 2 comments

Currently, the only way to infer the compaction score and heuristics is to use the LSM printout from the logs (emitted once every ten minutes), or to call the /debug/lsm endpoint manually, and track values over time. This makes it difficult to debug issues retroactively.

Add two new sets of per-LSM-level time-series metrics for level size and level score. These new metrics have names of the form storage.$LEVEL-level-{size,score}.

Add an additional enum value for metrics that are "unitless". For example, a "score".

Closes #88415.

Release note (ops change): Adds two new sets of per-LSM-level time-series metrics, one for level size and another for level score. These metrics are of the form storage.$LEVEL-level-{size,score}.

nicktrav avatar Sep 22 '22 20:09 nicktrav

This change is Reviewable

cockroach-teamcity avatar Sep 22 '22 20:09 cockroach-teamcity

Example of how these can be used:

Screen Shot 2022-09-22 at 12 25 49 PM

nicktrav avatar Sep 22 '22 20:09 nicktrav

TFTRs!

bors r=sumeerbhola,jbowens

nicktrav avatar Sep 23 '22 16:09 nicktrav

Build succeeded:

craig[bot] avatar Sep 23 '22 17:09 craig[bot]

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from d41cce07e6649d0f34cbbb03dc25eb9156055b2c to blathers/backport-release-22.1-88504: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

blathers-crl[bot] avatar Sep 23 '22 17:09 blathers-crl[bot]