cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

release-22.2: kvserver/batcheval: ignore UseRangeTombstonesForPointDeletes knob sometimes

Open blathers-crl[bot] opened this issue 3 years ago • 2 comments
trafficstars

Backport 1/1 commits from #88468 on behalf of @ajwerner.

/cc @cockroachdb/release


We want to ignore the point deletion knob for cases where we're deleting data from system tables watched by rangefeeds. Not doing so can lead to missed updates. This is particularly critical for cluster settings.

Fixes #87575 Fixes #87479 Fixes #88202

Release note: None


Release justification:

blathers-crl[bot] avatar Sep 22 '22 19:09 blathers-crl[bot]

Thanks for opening a backport.

Please check the backport criteria before merging:

  • [x] Patches should only be created for serious issues or test-only changes.
  • [x] Patches should not break backwards-compatibility.
  • [x] Patches should change as little code as possible.
  • [x] Patches should not change on-disk formats or node communication protocols.
  • [x] Patches should not add new functionality.
  • [x] Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

blathers-crl[bot] avatar Sep 22 '22 19:09 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Sep 22 '22 19:09 cockroach-teamcity