cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

persistedsqlstats: speed up a test

Open yuzefovich opened this issue 3 years ago • 2 comments
trafficstars

Previously, a single unit test could take on the order of 4 minutes (or even exceed 5 minute timeout, rarely) because the job monitor checks whether a cluster setting has been updated only every minute, and we update the cluster setting twice in a unit test. This commit makes it so that in a testing setup the check happens every second.

Release note: None

yuzefovich avatar Sep 22 '22 19:09 yuzefovich

This change is Reviewable

cockroach-teamcity avatar Sep 22 '22 19:09 cockroach-teamcity

TFTR!

bors r+

yuzefovich avatar Sep 22 '22 20:09 yuzefovich

Build succeeded:

craig[bot] avatar Sep 22 '22 22:09 craig[bot]

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 1cc47c2dc5e4883bac80f0638359a178c91b95b8 to blathers/backport-release-22.1-88496: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

blathers-crl[bot] avatar Sep 22 '22 22:09 blathers-crl[bot]

No need to backport this to 22.1 since the relevant changes from #86404 were not backported there.

yuzefovich avatar Sep 22 '22 22:09 yuzefovich