cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

gossip: Don't check if the network should be tightened so often

Open a-robinson opened this issue 3 years ago • 5 comments
trafficstars

Touches #51838. See the thread there for more detail, but the gist is that tightenNetwork gets called hundreds of times per second (taking a full mutex lock each time) on large clusters, even when nothing needs tightening.

Release note (performance improvement): Avoid wasteful contention on the gossip mutex caused by checking if the network needs tightening hundreds of times per second.

a-robinson avatar Sep 22 '22 15:09 a-robinson

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

blathers-crl[bot] avatar Sep 22 '22 15:09 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Sep 22 '22 15:09 cockroach-teamcity

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

blathers-crl[bot] avatar Sep 22 '22 15:09 blathers-crl[bot]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

blathers-crl[bot] avatar Sep 22 '22 15:09 blathers-crl[bot]

The release note isn't needed for this change because it doesn't require documentation changes.

Does that mean you'd like me to remove it from the commit?

a-robinson avatar Sep 22 '22 18:09 a-robinson

Build succeeded:

craig[bot] avatar Sep 23 '22 00:09 craig[bot]