cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

sql/catalog/typedesc: fix bug which partially hydrated a type

Open ajwerner opened this issue 3 years ago • 4 comments

In rare cases where we hit an error hydrating the contained type of an array alias type, we'd populate the name, but not the contents.

Fixes #85376

Release note (bug fix): Fixed a rare bug where errors could occur related to the use of arrays of enums.

ajwerner avatar Aug 11 '22 02:08 ajwerner

This change is Reviewable

cockroach-teamcity avatar Aug 11 '22 02:08 cockroach-teamcity

4352 runs so far, 0 failures, over 1h8m15s whereas before it'd always fail within 1000 runs. I feel good about calling this the fix.

ajwerner avatar Aug 11 '22 04:08 ajwerner

Build failed (retrying...):

craig[bot] avatar Aug 11 '22 07:08 craig[bot]

Build failed (retrying...):

craig[bot] avatar Aug 11 '22 10:08 craig[bot]

Build succeeded:

craig[bot] avatar Aug 11 '22 15:08 craig[bot]

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 6b37080e28773c45b56f5503611683d56ec451eb to blathers/backport-release-21.2-85940: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

blathers-crl[bot] avatar Aug 11 '22 15:08 blathers-crl[bot]