sql: fix conflicting udf options validation

[chengxiong-ruan]

A silly mistake that forgot to add option type to the map :(

Release note: None

[cockroach-teamcity]

This change is 

[chengxiong-ruan]

pkg/sql/opt/optbuilder/create_function.go line 72 at r1 (raw file):

Previously, mgartner (Marcus Gartner) wrote…

It's not a super performance critical code path, but the map and reflection are an anti-pattern. You could define a helper to check for duplicate options that simply stores a bool for each option type.

ah yeah, I agree, I'll make a helper for it. thanks.

[chengxiong-ruan]

TFTR! 🙏 bors r+

[craig[bot]]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig[bot]]

Build succeeded:

• Bazel Essential CI (Cockroach)