cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

clusterversion: bump min-supported version to 22.1

Open celiala opened this issue 2 years ago • 1 comments

Describe the problem

This issue tracks the work necessary to bump the min supported binary version on master. It'll need to be done before we cut any release for 22.2

https://github.com/cockroachdb/cockroach/blob/6cdd96b38f5b67c655a5697b6bf493b2c59041c1/pkg/clusterversion/cockroach_versions.go#L610-L615

[From previous major release, but reasoning still applies here] When doing so, we'll want to update some of our tests to override the min supported binary version for the reasons stated in https://github.com/cockroachdb/cockroach/pull/69828#issuecomment-946306532.

We need to also remove the old 22.1 cluster version gates:

  • [individual PR] PebbleFormatBlockPropertyCollector

Addressed in https://github.com/cockroachdb/cockroach/pull/85777:

  • [x] ProbeRequest
  • [individual PR] PublicSchemasWithDescriptors
  • [individual PR] EnsureSpanConfigReconciliation
  • [individual PR] EnsureSpanConfigSubscription
  • [individual PR] EnableSpanConfigStore
  • [x] SCRAMAuthentication
  • [x] UnsafeLossOfQuorumRecoveryRangeLog
  • [x] AlterSystemProtectedTimestampAddColumn

Addressed in https://github.com/cockroachdb/cockroach/pull/85793:

  • [x] EnableProtectedTimestampsForTenant
  • [x] DeleteCommentsWithDroppedIndexes
  • [x] RemoveIncompatibleDatabasePrivileges
  • [x] AddRaftAppliedIndexTermMigration
  • [x] PostAddRaftAppliedIndexTermMigration
  • [x] DontProposeWriteTimestampForLeaseTransfers
  • [x] EnablePebbleFormatVersionBlockProperties
  • [x] MVCCIndexBackfiller
  • [individual PR] EnableLeaseHolderRemoval
  • [x] LooselyCoupledRaftLogTruncation
  • [individual PR] ChangefeedIdleness
  • [***] EnableDeclarativeSchemaChanger
  • [x] RowLevelTTL
  • [individual PR] PebbleFormatSplitUserKeysMarked
  • [x] EnableNewStoreRebalancer
  • [individual PR] ClusterLocksVirtualTable
  • [individual PR] AutoStatsTableSettings
  • [x] SuperRegions
  • [x] EnableNewChangefeedOptions
  • [x] SpanCountTable
  • [x] PreSeedSpanCountTable
  • [x] SeedSpanCountTable

To be addressed in individual PRs:

  • https://github.com/cockroachdb/cockroach/pull/85854
    • [x] PebbleFormatBlockPropertyCollector
    • [x] PebbleFormatSplitUserKeysMarked
  • [x] PublicSchemasWithDescriptors https://github.com/cockroachdb/cockroach/pull/85825
  • https://github.com/cockroachdb/cockroach/pull/85848
    • [x] EnsureSpanConfigReconciliation
    • [x] EnsureSpanConfigSubscription
    • [x] EnableSpanConfigStore
  • [x] EnableLeaseHolderRemoval https://github.com/cockroachdb/cockroach/pull/85864
  • [ ] ChangefeedIdleness
  • [see 85854] PebbleFormatSplitUserKeysMarked
  • [ ] ClusterLocksVirtualTable
  • [ ] AutoStatsTableSettings

Jira issue: CRDB-18426 Jira issue: CRDB-15560

celiala avatar Apr 27 '22 20:04 celiala

Hi @celiala, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

blathers-crl[bot] avatar Apr 27 '22 20:04 blathers-crl[bot]

Removed

https://github.com/cockroachdb/cockroach/pull/85854

  • PebbleFormatBlockPropertyCollector
  • PebbleFormatSplitUserKeysMarked

Addressed in https://github.com/cockroachdb/cockroach/pull/85777:

  • kvserver: ProbeRequest,
  • security,pgwire: SCRAMAuthentication,
  • server: UnsafeLossOfQuorumRecoveryRangeLog,
  • kvserver: AlterSystemProtectedTimestampAddColumn
  • backupccl: EnableProtectedTimestampsForTenant
  • DeleteCommentsWithDroppedIndexes
  • sql/catalog: RemoveIncompatibleDatabasePrivileges
  • kvserver: AddRaftAppliedIndexTermMigration
  • clusterversion: PostAddRaftAppliedIndexTermMigration
  • kvserver: DontProposeWriteTimestampForLeaseTransfers
  • sql: MVCCIndexBackfiller
  • kvserver: LooselyCoupledRaftLogTruncation
  • sql: EnableDeclarativeSchemaChanger
  • kvserver: EnableNewStoreRebalancer
  • SpanCountTable
  • spanconfig: PreSeedSpanCountTable, SeedSpanCountTable

celiala avatar Aug 15 '22 14:08 celiala